Dealing with memory and speed issues in permutation analysis for large datasets #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @tengmx,
I ran into the problem reported here and dig into debugging the error. It is related to the
gcapcPeaksfunction. It turns out that, for some datasets, the vector of permuted values can be extremely large (>50 billion) and the functionsquantileanddensityjust break. I solved this by adding an option to sample permuted values from a uniform distribution. I added a parameterpermsamp=that indicates the fraction of permuted values to use for the size of the sample.I also modified some lines of code to speed them up. For the example dataset, these changes improve the runs by only ~5 seconds, but for larger datasets it makes a more substantial difference.
This version passes
R CMD checkwithout problems. Let me know if these suggestions make sense!Alejandro