Open
Conversation
DW_FORM_implicit_const takes a signed LEB128 immediately following the form.
tenderlove
approved these changes
Mar 5, 2022
Owner
tenderlove
left a comment
tenderlove
left a comment
There was a problem hiding this comment.
LGTM! Happy to merge if you are done with this PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a few issues I'm running into under arch linux+gcc
DW_FORM_implicit_constis immediately followed by a signed LEB128 value, which was causing tags to be read incorrectlyDW_FORM_line_strpis similar toDW_FORM_strpbut it reads from the.debug_line_strsection instead of.debug_strI haven't implemented the actual reading yet. It might be helpful to pass around some sort of file adapter object rather than individual sectionsSolved by passing multiple sections toname