fix(validator): use index instead of address in changeValidatorStatus to prevent front-running#2188
Merged
fix(validator): use index instead of address in changeValidatorStatus to prevent front-running#2188
Conversation
fgimenez
requested review from
0xKitsune,
howydev,
joshieDo,
klkvr,
legion2002 and
mattsse
as code owners
fgimenez
added
A-precompile
0xrusowsky
reviewed
Jan 21, 2026
Contributor
0xrusowsky
left a comment
0xrusowsky
left a comment
There was a problem hiding this comment.
on the rust impl, shouldn't we add a new function with the new type, and update the dispatcher to gatekeep this under T1?
this would be a breaking change if we have already called this fn
fgimenez
force-pushed
the
fgimenez/zellic-24
branch
from
8ed6990 to
c22891c
Compare
… to prevent front-running
fgimenez
force-pushed
the
fgimenez/zellic-24
branch
from
49e4262 to
9caf70c
Compare
Member
Author
@0xrusowsky good point, done here 9caf70c ptal |
0xrusowsky
approved these changes
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes ZELLIC-24
Fixes a front-running vulnerability in
changeValidatorStatusby using validator index instead of address. A malicious validator could front-run the owner'schangeValidatorStatus(validatorAddress, false)call by first callingrotateValidatorto change their address, causing the owner's deactivation to fail.Changed
changeValidatorStatusto accept auint64 indexparameter instead ofaddress validator. Since validator indices are stable positions in the array, the owner can now reliably deactivate validators regardless of address rotations.