fix: remove purl references and update stale secret_key docs#87
fix: remove purl references and update stale secret_key docs#87brendanjryan merged 2 commits intomainfrom
Conversation
- Remove purl.tempo.xyz prerequisite and CLI usage from api-server example - Replace with pympp client command - Fix stale docs claiming secret_key is auto-generated and persisted to .env (v0.4.0 requires explicit MPP_SECRET_KEY or secret_key param)
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 14a2fda790
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| ```bash | ||
| purl http://localhost:8000/paid | ||
| python -m mpp.fetch http://localhost:8000/paid |
There was a problem hiding this comment.
In the documented uv sync setup for examples/api-server, this command is not runnable: that environment only installs pympp[tempo,server] (examples/api-server/pyproject.toml:6-10), while the fetch client in this repo is a separate example package that exposes a fetch script (examples/fetch/pyproject.toml:8-9). There is no mpp.fetch module under src/mpp, so users following the README will hit ModuleNotFoundError instead of exercising the paid endpoint.
Useful? React with 👍 / 👎.
1 participant
Prep for open-sourcing pympp.
purl.tempo.xyzprerequisite and CLI usage from api-server example (internal tool, not accessible to external users)secret_keyis "auto-generated and persisted to.env" — v0.4.0 removed that behavior; now requires explicitMPP_SECRET_KEYenv var orsecret_keyparam