fix: grant pull-requests:write permission to reusable CI workflow changelog.yml (currently broken)#138
Conversation
The changelog workflow calls ci.yml via workflow_call, but the nested lint job requests pull-requests:write (for posting lint comments). Without explicit permissions on the caller job, it defaults to none. Amp-Thread-ID: https://ampcode.com/threads/T-019d06ee-d3d0-7154-a409-52566ccb4a22 Co-authored-by: Amp <amp@ampcode.com>
Tempo Lint ResultsSummaryFound 687 issue(s) across 41 file(s)
Issues by Rule Type
|
pull-requests:write permission to reusable CI workflow changelog.yml (currently broken)
Fixes the invalid workflow error in https://github.com/tempoxyz/mpp-rs/actions/workflows/changelog.yml
The
changelog.ymlworkflow callsci.ymlviaworkflow_call, but thelintjob inci.ymlrequestspull-requests: write(needed bytempoxyz/lintsto post comments). Without explicitpermissionson the caller's job, the reusable workflow inheritsnonefor undeclared permissions.Security: Safe — the trigger is
pull_request(notpull_request_target), so fork PRs get a read-onlyGITHUB_TOKENregardless. Same-repo PRs come from trusted collaborators.