Skip to content

Conversation

@brendanjryan
Copy link
Contributor

Summary

This PR fixes two issues that were breaking the tempo-lints GitHub Action:

1. pnpm version conflict in action.yml

Problem: The action hardcoded version: 9 for pnpm, which caused errors in projects using packageManager: "pnpm@10.x" because pnpm/action-setup@v4 throws when multiple pnpm versions are specified.

Fix: Replace pnpm/action-setup with corepack enable, which respects the action's own packageManager field.

2. Missing v0 tag due to release workflow mismatch

Problem:

  • The README documents using tempoxyz/lints@v0
  • release-tags.yml expects tags matching ^v([0-9]+)\.([0-9]+)\.([0-9]+)$ to create major version tags
  • But changeset tag creates tags like @tempoxyz/lints@0.1.1
  • The regex never matched, so v0 was never created

Fix:

  • Updated release.yml to create a vX.Y.Z tag from the changeset tag before creating the GitHub release
  • This allows release-tags.yml to properly create/update the major version tag (v0)

Manual tag creation

I also pushed v0.1.1 and v0 tags manually to fix the existing release:

  • v0.1.1 points to the same commit as @tempoxyz/lints@0.1.1
  • v0 points to v0.1.1

Test plan

  • Verify tempoxyz/lints@v0 now resolves correctly in GitHub Actions
  • Test the action in a project using pnpm 10+
  • Verify future releases create proper vX.Y.Z tags

1. action.yml: Replace pnpm/action-setup with corepack
   - The hardcoded `version: 9` conflicted with projects using pnpm 10+
   - pnpm/action-setup@v4 throws when packageManager field conflicts
   - Using corepack respects the action's own packageManager field

2. release.yml: Create vX.Y.Z tags from changeset tags
   - Changesets creates tags like @tempoxyz/lints@0.1.1
   - release-tags.yml expects vX.Y.Z format to create major version tags
   - Now creates v0.1.1 tag from @tempoxyz/lints@0.1.1 before releasing
   - This allows release-tags.yml to properly create/update v0 tag
@brendanjryan brendanjryan merged commit 7d7484f into main Jan 20, 2026
1 check passed
@brendanjryan brendanjryan deleted the fix/release-and-action-compat branch January 20, 2026 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants