Skip to content

Fix homepage showcase layout shift #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
decofe wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix homepage showcase layout shift #546

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/marketing/app/_components/TokensShowcase.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import Reveal from './Reveal'
const VISUAL_HEIGHT = 'lg:h-[424px]'
const CODE_HEIGHT = 'max-h-[390px]'
const DIAGRAM_CONTAINER = 'p-6 lg:min-h-0 lg:p-10'
const PANEL_HEIGHT = 'min-h-[454px]'
const SHOWCASE_HEIGHT = 'lg:min-h-[560px]'

type Row = {
Expand Down Expand Up @@ -320,7 +321,7 @@ export default function TokensShowcase() {
<div className="absolute top-6 right-6 z-20 lg:top-8 lg:right-10">
<ModeToggle mode={mode} setMode={setMode} />
</div>
<div className="grid w-full max-w-[560px] grid-cols-1">
<div className={`grid w-full max-w-[560px] grid-cols-1 ${PANEL_HEIGHT}`}>
{rows.map((row, i) => (
<Fragment key={row.title}>
<div
Expand Down
3 changes: 2 additions & 1 deletion src/marketing/app/_components/TransactionsShowcase.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import {
const VISUAL_HEIGHT = 'lg:h-[424px]'
const CODE_HEIGHT = 'max-h-[390px]'
const DIAGRAM_CONTAINER = 'p-6 lg:min-h-0 lg:p-10'
const PANEL_HEIGHT = 'min-h-[454px]'
const SHOWCASE_HEIGHT = 'lg:min-h-[560px]'

type Row = {
Expand Down Expand Up @@ -149,7 +150,7 @@ export default function TransactionsShowcase() {
<div className="absolute top-6 right-6 z-20 lg:top-8 lg:right-10">
<ModeToggle mode={mode} setMode={setMode} />
</div>
<div className="grid w-full max-w-[560px] grid-cols-1">
<div className={`grid w-full max-w-[560px] grid-cols-1 ${PANEL_HEIGHT}`}>
{rows.map((row, i) => (
<Fragment key={row.title}>
<div
Expand Down
Loading