fix: stricter version matching and workspace root detection#79
Merged
Conversation
…tion - action.yml: Replace index($0, ver) substring match with regex anchored match to prevent partial version collisions (e.g., '1.0' matching '1.0.1') - rust.rs: Use toml_edit parsing instead of string contains to detect workspace root, preventing false matches from comments or strings Amp-Thread-ID: https://ampcode.com/threads/T-019d0268-a225-76d0-951a-b0991bcdda1f Co-authored-by: Amp <amp@ampcode.com>
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two bug fixes found during code review of the unified workspace versioning changes (PRs #76 and #78):
1. action.yml — partial version string matching (high severity)
index($0, ver)performs a substring match, so version1.0would match## 1.0.1or## 11.0.0, causing incorrect changelog extraction for GitHub Releases.Fix: Use an anchored regex
$0 ~ "^## " ver "[ (]"that requires the version to appear right after##and be followed by a space or(.2. rust.rs — fragile workspace root detection (medium severity)
content.contains("[workspace]")could false-match comments or string values likefeatures = ["workspace"].Fix: Parse the TOML properly with
toml_editand checkdoc.get("workspace").is_some().Testing
cargo test --lib -- rust— 16/16 passedcargo check— clean