-
Notifications
You must be signed in to change notification settings - Fork 0
refactor: consolidate deploy workflows #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bpierre
merged 8 commits into
feat/waku-migration
from
bpierre/chore-refactor-workflows
Jan 20, 2026
Merged
refactor: consolidate deploy workflows #33
bpierre
merged 8 commits into
feat/waku-migration
from
bpierre/chore-refactor-workflows
Jan 20, 2026
+211
−438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed action - Merge deploy-preview-moderato and deploy-preview-presto into single deploy-preview workflow - Merge deploy-moderato and deploy-presto into single deploy workflow - Create reusable deploy action for both preview and prod - Both envs now deploy in parallel within same workflow - Fix PR comment race condition (was showing only one env) - Improve deployment table format with commit hash and relative time Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Use matrix strategy for parallel deploys - Simplify PR comment: ### Preview header, neutral timestamp - Pass deployment results via artifacts Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
struong
reviewed
Jan 20, 2026
Contributor
struong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tres bon
struong
approved these changes
Jan 20, 2026
bpierre
added a commit
that referenced
this pull request
Jan 21, 2026
* waku * fix: env variable access for waku server functions - Use process.env instead of import.meta.env for TEMPO_ENV - Remove import.meta.env fallback for INDEXER_API_KEY - Add process.env fallback for PRESTO_RPC_AUTH in local dev - Fix indentation in fetchAssets Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: move client providers outside Layout component - Wrap Layout with client providers instead of wrapping children inside Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * refactor: consolidate server env access into shared module - Add src/lib/server/env.ts with shared env utilities - Extract getTempoEnv, getRpcAuth, getIndexerApiKey helpers - Add getRpcUrl, shouldUseAuth, getChainId pure functions - Update transactions, assets, access-keys, onramp server files - Remove ~30 lines of duplicated cloudflare/process.env logic Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix tokens metadata fetching * checks * checks * cloudflare * Merge branch 'main' into feat/waku-migration * use forwarded auth for faucet in Waku * update generated files * fix rpc auth forwarding * do not format pages.gen.ts * fix: use dynamic import for cloudflare:workers * feat(onramp): waku migration (#29) * checks * checks * cloudflare * refactor: use config module for onramp instead of direct env access * feat: add useTestOtpCode config for onramp OTP bypass in dev/testnet * refactor: extract env helpers for fulfill.ts * chore: pnpm check * chore: delete redundant rpc.ts --------- Co-authored-by: Steven Truong <struong@users.noreply.github.com> Co-authored-by: Pierre Bertet <hi@bpier.re> * fix: remove /keys suffix from key manager URLs * bundle size * read RPC auth from headers when FORWARD_RPC_AUTH=1 * refactor: consolidate deploy workflows (#33) ## Summary - Consolidate 4 deploy workflows into 2 using matrix strategy - Create reusable deploy action shared by preview and prod - Fix PR comment race condition (was showing only one env) - Remove duplicate verify run on PRs - Remove build from verify (deploys build anyway) - saves 1 build cycle - Improve deployment table format ## Before/After **Before:** - 4 workflows + 1 action (436 lines) - Verify runs twice on PRs - 3 builds per PR (verify + 2 deploys) - Race condition on PR comment **After:** - 2 workflows + 1 action (177 lines) - Verify runs once - 2 builds per PR (deploy only) - Single PR comment with both envs * capture headers before await to preserve AsyncLocalStorage context * log connection error * adapt rpId to the workers.dev preview domains * layout fixes * ui tweaks --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> Co-authored-by: struong <10735730+struong@users.noreply.github.com> Co-authored-by: Steven Truong <struong@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Before/After
Before:
After:
🤖 Generated with Claude Code