Skip to content

Set the "missing" key in ES sorter#8964

Merged
rodrigozhou merged 1 commit intomainfrom
rodrigozhou/opensearch3
Jan 12, 2026
Merged

Set the "missing" key in ES sorter#8964
rodrigozhou merged 1 commit intomainfrom
rodrigozhou/opensearch3

Conversation

@rodrigozhou
Copy link
Copy Markdown
Contributor

@rodrigozhou rodrigozhou commented Jan 8, 2026 •
edited
Loading

What changed?

Explicitly set the "missing" key in ES sorter. This is to address pagination bug in OpenSearch 2.8.0+ (see opensearch-project/OpenSearch#8212 (comment)).

Run CI tests with latest version of OpenSearch 2 and OpenSearch 3.

Why?

Full support of OpenSearch as visibility store.
Issue: #5680

How did you test it?

  • built
  • run locally and tested manually
  • covered by existing tests
  • added new unit test(s)
  • added new functional test(s)

Potential risks

@semgrep-managed-scans
Copy link
Copy Markdown

semgrep-managed-scans Bot commented Jan 8, 2026

Semgrep found 4 missing-explicit-permissions findings:

No explicit GITHUB_TOKEN permissions found at the workflow or job level. Add a permissions: block at the workflow root (applies to all jobs) or per job with least privilege (e.g., contents: read and only specific writes like pull-requests: write if needed).

@rodrigozhou rodrigozhou force-pushed the rodrigozhou/opensearch3 branch 4 times, most recently from 5faed84 to 6c98e20 Compare January 9, 2026 00:33
@rodrigozhou rodrigozhou force-pushed the rodrigozhou/opensearch3 branch from 6c98e20 to cd57af6 Compare January 9, 2026 00:55
@rodrigozhou rodrigozhou marked this pull request as ready for review January 9, 2026 18:36
@rodrigozhou rodrigozhou requested review from a team as code owners January 9, 2026 18:36
@rodrigozhou rodrigozhou changed the title Run CI tests with OpenSearch 3 Set the "missing" key in ES sorter Jan 9, 2026
awln-temporal
awln-temporal reviewed Jan 12, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@awln-temporal awln-temporal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fmi, what is the bug fix here? From what I understand, the bug in OpenSearch 2.8.0 was occurring when users specify any missing flag in the sorter. Why are we explicitly setting it now as a fix?

@rodrigozhou rodrigozhou merged commit dbc08f1 into main Jan 12, 2026
71 checks passed
@rodrigozhou rodrigozhou deleted the rodrigozhou/opensearch3 branch January 12, 2026 19:32
@rodrigozhou rodrigozhou mentioned this pull request Jan 12, 2026
Closed
@rodrigozhou
Copy link
Copy Markdown
Contributor Author

rodrigozhou commented Jan 12, 2026

@awln-temporal The bug is when missing is not explicitly set, pagination doesn't work correctly when there are null values in the fields in the sorting key.

simvlad pushed a commit that referenced this pull request Jan 27, 2026
@rodrigozhou @simvlad
Set the "missing" key in ES sorter (#8964)
172f9b7 
## What changed?
Explicitly set the `"missing"` key in ES sorter. This is to address
pagination bug in OpenSearch 2.8.0+ (see
opensearch-project/OpenSearch#8212 (comment)).

Run CI tests with latest version of OpenSearch 2 and OpenSearch 3.

## Why?
Full support of OpenSearch as visibility store.

## How did you test it?
- [ ] built
- [ ] run locally and tested manually
- [x] covered by existing tests
- [ ] added new unit test(s)
- [ ] added new functional test(s)

## Potential risks
@barryib
Copy link
Copy Markdown

barryib commented Feb 11, 2026

Can we add this support into the doc to clearly highlight that Opensearch is supported ?

@awln-temporal awln-temporal mentioned this pull request Feb 11, 2026
Merged
@rodrigozhou
Copy link
Copy Markdown
Contributor Author

rodrigozhou commented Feb 25, 2026

@barryib Once v1.30.1 is released, the docs will be updated.

@chaptersix chaptersix mentioned this pull request Feb 27, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@awln-temporal awln-temporal awln-temporal approved these changes

Assignees

No one assigned

Labels

release/1.30.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rodrigozhou @barryib @awln-temporal