Skip to content

Remove stdlib_module_names test that is no longer relevant #1259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VegetarianOrc wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove stdlib_module_names test that is no longer relevant #1259

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d6038ae
Remove stdlib_module_names test that is no longer relevant
VegetarianOrc Dec 19, 2025
efdd943
Merge branch 'main' into remove-stdlib_module_names-test
tconley1428 Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 0 additions & 19 deletions tests/worker/workflow_sandbox/test_restrictions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,25 +16,6 @@
)


def test_workflow_sandbox_stdlib_module_names():
if sys.version_info[1] != 11:
pytest.skip("Test only runs on 3.11")
actual_names = ",".join(sorted(sys.stdlib_module_names))
# Uncomment to print code for generating these
code_lines = [""]
for mod_name in sorted(sys.stdlib_module_names):
if code_lines[-1]:
code_lines[-1] += ","
if len(code_lines[-1]) > 80:
code_lines.append("")
code_lines[-1] += mod_name
code = '_stdlib_module_names = (\n "' + '"\n "'.join(code_lines) + '"\n)'
# TODO(cretz): Point releases may add modules :-(
assert actual_names == ",".join(
sys.stdlib_module_names
), f"Expecting names as {actual_names}. In code as:\n{code}"


def test_workflow_sandbox_restrictions_add_passthrough_modules():
updated = SandboxRestrictions.default.with_passthrough_modules("module1", "module2")
assert (
Expand Down
Loading