Adds basedpyright support to poe lint

pyproject.toml

@@ -38,6 +38,7 @@ Documentation = "https://docs.temporal.io/docs/python"
 
 [dependency-groups]
 dev = [
+  "basedpyright==1.34.0",
   "cibuildwheel>=2.22.0,<3",
   "grpcio-tools>=1.48.2,<2",
   "mypy==1.18.2",
@@ -96,6 +97,7 @@ lint-docs = "uv run pydocstyle --ignore-decorators=overload"
 lint-types = [
   { cmd = "uv run pyright" },
   { cmd = "uv run mypy --namespace-packages --check-untyped-defs ." },
+  { cmd = "uv run basedpyright" }
 ]
 run-bench = "uv run python scripts/run_bench.py"
 test = "uv run pytest"
@@ -200,11 +202,13 @@ reportUnknownVariableType = "none"
 reportUnnecessaryIsInstance = "none"
 reportUnnecessaryTypeIgnoreComment = "none"
 reportUnusedCallResult = "none"
+reportUnknownLambdaType = "none"
 include = ["temporalio", "tests"]
 exclude = [
   # Exclude auto generated files
   "temporalio/api",
   "temporalio/bridge/proto",
+  "temporalio/bridge/_visitor.py",
   "tests/worker/workflow_sandbox/testmodules/proto",
 ]
 

scripts/gen_protos.py

@@ -7,7 +7,6 @@
 from collections.abc import Mapping
 from functools import partial
 from pathlib import Path
-from typing import List
 
 base_dir = Path(__file__).parent.parent
 proto_dir = (

temporalio/activity.py

@@ -22,12 +22,7 @@
 from typing import (
     TYPE_CHECKING,
     Any,
-    List,
     NoReturn,
-    Optional,
-    Tuple,
-    Type,
-    Union,
     overload,
 )
 
@@ -593,7 +588,7 @@ def _apply_to_callable(
         if hasattr(fn, "__temporal_activity_definition"):
             raise ValueError("Function already contains activity definition")
         elif not callable(fn):
-            raise TypeError("Activity is not callable")
+            raise TypeError("Activity is not callable")  # type:ignore[reportUnreachable]
         # We do not allow keyword only arguments in activities
         sig = inspect.signature(fn)
         for param in sig.parameters.values():

temporalio/bridge/client.py

@@ -8,13 +8,15 @@
 from collections.abc import Mapping
 from dataclasses import dataclass
 from datetime import timedelta
-from typing import Optional, Tuple, Type, TypeVar, Union
+from typing import TypeVar
 
 import google.protobuf.message
 
 import temporalio.bridge.runtime
 import temporalio.bridge.temporal_sdk_bridge
-from temporalio.bridge.temporal_sdk_bridge import RPCError
+from temporalio.bridge.temporal_sdk_bridge import (
+    RPCError,  # type:ignore[reportUnusedImport]
+)
 
 
 @dataclass

temporalio/bridge/metric.py

@@ -6,7 +6,6 @@
 from __future__ import annotations
 
 from collections.abc import Mapping
-from typing import Optional, Union
 
 import temporalio.bridge.runtime
 import temporalio.bridge.temporal_sdk_bridge

temporalio/bridge/runtime.py

@@ -7,7 +7,7 @@
 
 from collections.abc import Callable, Mapping, Sequence
 from dataclasses import dataclass
-from typing import Any, Dict, Optional, Type
+from typing import Any
 
 from typing_extensions import Protocol
 

temporalio/bridge/testing.py

@@ -7,7 +7,6 @@
 
 from collections.abc import Sequence
 from dataclasses import dataclass
-from typing import Optional
 
 import temporalio.bridge.runtime
 import temporalio.bridge.temporal_sdk_bridge

temporalio/bridge/worker.py

@@ -8,16 +8,9 @@
 from collections.abc import Awaitable, Callable, MutableSequence, Sequence
 from dataclasses import dataclass
 from typing import (
-    List,
-    Optional,
-    Set,
-    Tuple,
     TypeAlias,
-    Union,
 )
 
-import temporalio.api.common.v1
-import temporalio.api.history.v1
 import temporalio.bridge.client
 import temporalio.bridge.proto
 import temporalio.bridge.proto.activity_task
@@ -27,7 +20,6 @@
 import temporalio.bridge.runtime
 import temporalio.bridge.temporal_sdk_bridge
 import temporalio.converter
-import temporalio.exceptions
 from temporalio.api.common.v1.message_pb2 import Payload
 from temporalio.bridge._visitor import VisitorFunctions
 from temporalio.bridge.temporal_sdk_bridge import (
@@ -80,10 +72,7 @@ class PollerBehaviorAutoscaling:
     initial: int
 
 
-PollerBehavior: TypeAlias = Union[
-    PollerBehaviorSimpleMaximum,
-    PollerBehaviorAutoscaling,
-]
+PollerBehavior: TypeAlias = PollerBehaviorSimpleMaximum | PollerBehaviorAutoscaling
 
 
 @dataclass
@@ -118,11 +107,11 @@ class WorkerVersioningStrategyLegacyBuildIdBased:
     build_id_with_versioning: str
 
 
-WorkerVersioningStrategy: TypeAlias = Union[
-    WorkerVersioningStrategyNone,
-    WorkerDeploymentOptions,
-    WorkerVersioningStrategyLegacyBuildIdBased,
-]
+WorkerVersioningStrategy: TypeAlias = (
+    WorkerVersioningStrategyNone
+    | WorkerDeploymentOptions
+    | WorkerVersioningStrategyLegacyBuildIdBased
+)
 
 
 @dataclass
@@ -150,11 +139,9 @@ class FixedSizeSlotSupplier:
     num_slots: int
 
 
-SlotSupplier: TypeAlias = Union[
-    FixedSizeSlotSupplier,
-    ResourceBasedSlotSupplier,
-    BridgeCustomSlotSupplier,
-]
+SlotSupplier: TypeAlias = (
+    FixedSizeSlotSupplier | ResourceBasedSlotSupplier | BridgeCustomSlotSupplier
+)
 
 
 @dataclass

temporalio/client.py

@@ -28,14 +28,7 @@
 from typing import (
     Any,
     Concatenate,
-    Dict,
-    FrozenSet,
     Generic,
-    Optional,
-    Text,
-    Tuple,
-    Type,
-    Union,
     cast,
     overload,
 )
@@ -205,7 +198,9 @@ async def connect(
             http_connect_proxy_config=http_connect_proxy_config,
         )
 
-        def make_lambda(plugin, next):
+        def make_lambda(
+            plugin: Plugin, next: Callable[[ConnectConfig], Awaitable[ServiceClient]]
+        ):
             return lambda config: plugin.connect_service_client(config, next)
 
         next_function = ServiceClient.connect
@@ -3397,7 +3392,7 @@ def next_page_token(self) -> bytes | None:
         """Token for the next page request if any."""
         return self._next_page_token
 
-    async def fetch_next_page(self, *, page_size: int | None = None) -> None:
+    async def fetch_next_page(self, *, page_size: int | None = None) -> None:  # type:ignore[reportUnusedParameter] # https://github.com/temporalio/sdk-python/issues/1239
         """Fetch the next page if any.
 
         Args:
@@ -4148,7 +4143,7 @@ def __init__(
                     raise ValueError("Cannot schedule dynamic workflow explicitly")
                 workflow = defn.name
             elif not isinstance(workflow, str):
-                raise TypeError("Workflow must be a string or callable")
+                raise TypeError("Workflow must be a string or callable")  # type:ignore[reportUnreachable]
             self.workflow = workflow
             self.args = temporalio.common._arg_or_args(arg, args)
             self.id = id
@@ -6032,9 +6027,9 @@ async def _populate_start_workflow_execution_request(
             req.user_metadata.CopyFrom(metadata)
         if input.start_delay is not None:
             req.workflow_start_delay.FromTimedelta(input.start_delay)
-        if input.headers is not None:
+        if input.headers is not None:  # type:ignore[reportUnnecessaryComparison]
             await self._apply_headers(input.headers, req.header.fields)
-        if input.priority is not None:
+        if input.priority is not None:  # type:ignore[reportUnnecessaryComparison]
             req.priority.CopyFrom(input.priority._to_proto())
         if input.versioning_override is not None:
             req.versioning_override.CopyFrom(input.versioning_override._to_proto())
@@ -6130,7 +6125,7 @@ async def query_workflow(self, input: QueryWorkflowInput) -> Any:
             req.query.query_args.payloads.extend(
                 await data_converter.encode(input.args)
             )
-        if input.headers is not None:
+        if input.headers is not None:  # type:ignore[reportUnnecessaryComparison]
             await self._apply_headers(input.headers, req.query.header.fields)
         try:
             resp = await self._client.workflow_service.query_workflow(
@@ -6178,7 +6173,7 @@ async def signal_workflow(self, input: SignalWorkflowInput) -> None:
         )
         if input.args:
             req.input.payloads.extend(await data_converter.encode(input.args))
-        if input.headers is not None:
+        if input.headers is not None:  # type:ignore[reportUnnecessaryComparison]
             await self._apply_headers(input.headers, req.header.fields)
         await self._client.workflow_service.signal_workflow_execution(
             req, retry=True, metadata=input.rpc_metadata, timeout=input.rpc_timeout
@@ -6299,7 +6294,7 @@ async def _build_update_workflow_execution_request(
             req.request.input.args.payloads.extend(
                 await data_converter.encode(input.args)
             )
-        if input.headers is not None:
+        if input.headers is not None:  # type:ignore[reportUnnecessaryComparison]
             await self._apply_headers(input.headers, req.request.input.header.fields)
         return req
 

temporalio/common.py

@@ -14,14 +14,8 @@
     Any,
     ClassVar,
     Generic,
-    List,
-    Optional,
-    Text,
-    Tuple,
-    Type,
     TypeAlias,
     TypeVar,
-    Union,
     get_origin,
     get_type_hints,
     overload,
@@ -198,13 +192,13 @@ def __setstate__(self, state: object) -> None:
 # We choose to make this a list instead of an sequence so we can catch if people
 # are not sending lists each time but maybe accidentally sending a string (which
 # is a sequence)
-SearchAttributeValues: TypeAlias = Union[
-    list[str], list[int], list[float], list[bool], list[datetime]
-]
+SearchAttributeValues: TypeAlias = (
+    list[str] | list[int] | list[float] | list[bool] | list[datetime]
+)
 
 SearchAttributes: TypeAlias = Mapping[str, SearchAttributeValues]
 
-SearchAttributeValue: TypeAlias = Union[str, int, float, bool, datetime, Sequence[str]]
+SearchAttributeValue: TypeAlias = str | int | float | bool | datetime | Sequence[str]
 
 SearchAttributeValueType = TypeVar(
     "SearchAttributeValueType", str, int, float, bool, datetime, Sequence[str]
@@ -492,7 +486,7 @@ def __contains__(self, key: object) -> bool:
 
         This uses key equality so the key must be the same name and type.
         """
-        return any(k == key for k, v in self)
+        return any(k == key for k, _v in self)
 
     @overload
     def get(
@@ -544,7 +538,7 @@ def updated(self, *search_attributes: SearchAttributePair) -> TypedSearchAttribu
 TypedSearchAttributes.empty = TypedSearchAttributes(search_attributes=[])
 
 
-def _warn_on_deprecated_search_attributes(
+def _warn_on_deprecated_search_attributes(  # type:ignore[reportUnusedFunction]
     attributes: SearchAttributes | Any | None,
     stack_level: int = 2,
 ) -> None:
@@ -556,7 +550,7 @@ def _warn_on_deprecated_search_attributes(
         )
 
 
-MetricAttributes: TypeAlias = Mapping[str, Union[str, int, float, bool]]
+MetricAttributes: TypeAlias = Mapping[str, str | int | float | bool]
 
 
 class MetricMeter(ABC):
@@ -1157,15 +1151,15 @@ def _to_proto(self) -> temporalio.api.workflow.v1.VersioningOverride:
 _arg_unset = object()
 
 
-def _arg_or_args(arg: Any, args: Sequence[Any]) -> Sequence[Any]:
+def _arg_or_args(arg: Any, args: Sequence[Any]) -> Sequence[Any]:  # type:ignore[reportUnusedFunction]
     if arg is not _arg_unset:
         if args:
             raise ValueError("Cannot have arg and args")
         args = [arg]
     return args
 
 
-def _apply_headers(
+def _apply_headers(  # type:ignore[reportUnusedFunction]
     source: Mapping[str, temporalio.api.common.v1.Payload] | None,
     dest: google.protobuf.internal.containers.MessageMap[
         str, temporalio.api.common.v1.Payload
@@ -1192,7 +1186,7 @@ def _apply_headers(
 )
 
 
-def _type_hints_from_func(
+def _type_hints_from_func(  # type:ignore[reportUnusedFunction]
     func: Callable,
 ) -> tuple[list[type] | None, type | None]:
     """Extracts the type hints from the function.

temporalio/contrib/openai_agents/__init__.py

@@ -17,9 +17,6 @@
     OpenAIAgentsPlugin,
     OpenAIPayloadConverter,
 )
-from temporalio.contrib.openai_agents._trace_interceptor import (
-    OpenAIAgentsTracingInterceptor,
-)
 from temporalio.contrib.openai_agents.workflow import AgentsWorkflowError
 
 from . import testing, workflow

temporalio/contrib/openai_agents/_heartbeat_decorator.py

@@ -8,7 +8,7 @@
 F = TypeVar("F", bound=Callable[..., Awaitable[Any]])
 
 
-def _auto_heartbeater(fn: F) -> F:
+def _auto_heartbeater(fn: F) -> F:  # type:ignore[reportUnusedClass]
     # Propagate type hints from the original callable.
     @wraps(fn)
     async def wrapper(*args: Any, **kwargs: Any) -> Any: