Skip to content

fix: use Client subclient pattern for async activity completion #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chris-olszewski merged 1 commit into from
Mar 9, 2026
Merged

fix: use Client subclient pattern for async activity completion #451

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions activities-examples/src/activities/async-completion.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// @@@SNIPSTART typescript-activity-complete-async
import { CompleteAsyncError, activityInfo } from '@temporalio/activity';
import { AsyncCompletionClient } from '@temporalio/client';
import { Client } from '@temporalio/client';

export async function doSomethingAsync(): Promise<string> {
const taskToken = activityInfo().taskToken;
Expand All @@ -10,8 +10,8 @@ export async function doSomethingAsync(): Promise<string> {

// this work could be done in a different process or on a different machine
async function doSomeWork(taskToken: Uint8Array): Promise<void> {
const client = new AsyncCompletionClient();
const client = new Client();
// does some work...
await client.complete(taskToken, "Job's done!");
await client.activity.complete(taskToken, "Job's done!");
}
// @@@SNIPEND