Skip to content

chore: pr 449 feedback #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chris-olszewski merged 3 commits into from
Feb 26, 2026
Merged

chore: pr 449 feedback #450

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2d8a22a
chore: remove unused script
chris-olszewski Feb 26, 2026
358506f
chore: upgrade to @tsconfig/node22
chris-olszewski Feb 26, 2026
6043783
chore(otel): add back prebuilt comment use batch processor
chris-olszewski Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .shared/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": "@tsconfig/node18/tsconfig.json",
"extends": "@tsconfig/node22/tsconfig.json",
"version": "5.6.3",
"compilerOptions": {
"lib": ["es2021"],
Expand Down
2 changes: 1 addition & 1 deletion activities-cancellation-heartbeating/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"@temporalio/workflow": "^1.15.0"
},
"devDependencies": {
"@tsconfig/node18": "^18.2.4",
"@tsconfig/node22": "^22.0.0",
"@types/node": "^22.9.1",
"@typescript-eslint/eslint-plugin": "^8.18.0",
"@typescript-eslint/parser": "^8.18.0",
Expand Down
2 changes: 1 addition & 1 deletion activities-cancellation-heartbeating/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": "@tsconfig/node18/tsconfig.json",
"extends": "@tsconfig/node22/tsconfig.json",
"version": "5.6.3",
"compilerOptions": {
"lib": ["es2021"],
Expand Down
2 changes: 1 addition & 1 deletion activities-dependency-injection/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"@temporalio/workflow": "^1.15.0"
},
"devDependencies": {
"@tsconfig/node18": "^18.2.4",
"@tsconfig/node22": "^22.0.0",
"@types/node": "^22.9.1",
"@typescript-eslint/eslint-plugin": "^8.18.0",
"@typescript-eslint/parser": "^8.18.0",
Expand Down
2 changes: 1 addition & 1 deletion activities-dependency-injection/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": "@tsconfig/node18/tsconfig.json",
"extends": "@tsconfig/node22/tsconfig.json",
"version": "5.6.3",
"compilerOptions": {
"lib": ["es2021"],
Expand Down
2 changes: 1 addition & 1 deletion activities-examples/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"devDependencies": {
"@temporalio/nyc-test-coverage": "^1.15.0",
"@temporalio/testing": "^1.15.0",
"@tsconfig/node18": "^18.2.4",
"@tsconfig/node22": "^22.0.0",
"@types/jest": "^27.5.1",
"@types/mocha": "8.x",
"@types/node": "^22.9.1",
Expand Down
2 changes: 1 addition & 1 deletion activities-examples/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": "@tsconfig/node18/tsconfig.json",
"extends": "@tsconfig/node22/tsconfig.json",
"version": "5.6.3",
"compilerOptions": {
"lib": ["es2021"],
Expand Down
2 changes: 1 addition & 1 deletion ai-sdk/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
},
"devDependencies": {
"@temporalio/testing": "^1.15.0",
"@tsconfig/node18": "^18.2.4",
"@tsconfig/node22": "^22.0.0",
"@types/mocha": "8.x",
"@types/node": "^22.9.1",
"@typescript-eslint/eslint-plugin": "^8.18.0",
Expand Down
2 changes: 1 addition & 1 deletion ai-sdk/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": "@tsconfig/node18/tsconfig.json",
"extends": "@tsconfig/node22/tsconfig.json",
"version": "5.6.3",
"compilerOptions": {
"lib": ["es2021"],
Expand Down
2 changes: 1 addition & 1 deletion child-workflows/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"@temporalio/workflow": "^1.15.0"
},
"devDependencies": {
"@tsconfig/node18": "^18.2.4",
"@tsconfig/node22": "^22.0.0",
"@types/node": "^22.9.1",
"@typescript-eslint/eslint-plugin": "^8.18.0",
"@typescript-eslint/parser": "^8.18.0",
Expand Down
2 changes: 1 addition & 1 deletion child-workflows/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": "@tsconfig/node18/tsconfig.json",
"extends": "@tsconfig/node22/tsconfig.json",
"version": "5.6.3",
"compilerOptions": {
"lib": ["es2021"],
Expand Down
2 changes: 1 addition & 1 deletion continue-as-new/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"@temporalio/workflow": "^1.15.0"
},
"devDependencies": {
"@tsconfig/node18": "^18.2.4",
"@tsconfig/node22": "^22.0.0",
"@types/node": "^22.9.1",
"@typescript-eslint/eslint-plugin": "^8.18.0",
"@typescript-eslint/parser": "^8.18.0",
Expand Down
2 changes: 1 addition & 1 deletion continue-as-new/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": "@tsconfig/node18/tsconfig.json",
"extends": "@tsconfig/node22/tsconfig.json",
"version": "5.6.3",
"compilerOptions": {
"lib": ["es2021"],
Expand Down
2 changes: 1 addition & 1 deletion cron-workflows/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"@temporalio/workflow": "^1.15.0"
},
"devDependencies": {
"@tsconfig/node18": "^18.2.4",
"@tsconfig/node22": "^22.0.0",
"@types/node": "^22.9.1",
"@typescript-eslint/eslint-plugin": "^8.18.0",
"@typescript-eslint/parser": "^8.18.0",
Expand Down
2 changes: 1 addition & 1 deletion cron-workflows/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": "@tsconfig/node18/tsconfig.json",
"extends": "@tsconfig/node22/tsconfig.json",
"version": "5.6.3",
"compilerOptions": {
"lib": ["es2021"],
Expand Down
2 changes: 1 addition & 1 deletion custom-logger/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"winston": "^3.3.3"
},
"devDependencies": {
"@tsconfig/node18": "^18.2.4",
"@tsconfig/node22": "^22.0.0",
"@types/node": "^22.9.1",
"@types/triple-beam": "^1.3.2",
"@typescript-eslint/eslint-plugin": "^8.18.0",
Expand Down
2 changes: 1 addition & 1 deletion custom-logger/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": "@tsconfig/node18/tsconfig.json",
"extends": "@tsconfig/node22/tsconfig.json",
"version": "5.6.3",
"compilerOptions": {
"lib": ["es2021"],
Expand Down
2 changes: 1 addition & 1 deletion dsl-interpreter/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"js-yaml": "^4.1.0"
},
"devDependencies": {
"@tsconfig/node18": "^18.2.4",
"@tsconfig/node22": "^22.0.0",
"@types/js-yaml": "^4.0.5",
"@types/node": "^22.9.1",
"@typescript-eslint/eslint-plugin": "^8.18.0",
Expand Down
2 changes: 1 addition & 1 deletion dsl-interpreter/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": "@tsconfig/node18/tsconfig.json",
"extends": "@tsconfig/node22/tsconfig.json",
"version": "5.6.3",
"compilerOptions": {
"lib": ["es2021"],
Expand Down
2 changes: 1 addition & 1 deletion eager-workflow-start/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
},
"devDependencies": {
"@temporalio/testing": "^1.15.0",
"@tsconfig/node18": "^18.2.4",
"@tsconfig/node22": "^22.0.0",
"@types/jest": "^29.5.14",
"@types/node": "^22.9.1",
"@typescript-eslint/eslint-plugin": "^8.18.0",
Expand Down
2 changes: 1 addition & 1 deletion eager-workflow-start/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": "@tsconfig/node18/tsconfig.json",
"extends": "@tsconfig/node22/tsconfig.json",
"version": "5.6.3",
"compilerOptions": {
"lib": ["es2021"],
Expand Down
2 changes: 1 addition & 1 deletion early-return/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
},
"devDependencies": {
"@temporalio/testing": "^1.15.0",
"@tsconfig/node18": "^18.2.4",
"@tsconfig/node22": "^22.0.0",
"@types/mocha": "8.x",
"@types/node": "^22.9.1",
"@typescript-eslint/eslint-plugin": "^8.18.0",
Expand Down
2 changes: 1 addition & 1 deletion early-return/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": "@tsconfig/node18/tsconfig.json",
"extends": "@tsconfig/node22/tsconfig.json",
"version": "5.6.3",
"compilerOptions": {
"lib": ["es2021"],
Expand Down
2 changes: 1 addition & 1 deletion ejson/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"uuid": "^8.3.2"
},
"devDependencies": {
"@tsconfig/node18": "^18.2.4",
"@tsconfig/node22": "^22.0.0",
"@types/ejson": "^2.1.3",
"@types/node": "^22.9.1",
"@types/uuid": "^8.3.4",
Expand Down
2 changes: 1 addition & 1 deletion ejson/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": "@tsconfig/node18/tsconfig.json",
"extends": "@tsconfig/node22/tsconfig.json",
"version": "5.6.3",
"compilerOptions": {
"lib": ["es2021"],
Expand Down
2 changes: 1 addition & 1 deletion empty/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
},
"devDependencies": {
"@temporalio/testing": "^1.15.0",
"@tsconfig/node18": "^18.2.4",
"@tsconfig/node22": "^22.0.0",
"@types/mocha": "8.x",
"@types/node": "^22.9.1",
"@typescript-eslint/eslint-plugin": "^8.18.0",
Expand Down
2 changes: 1 addition & 1 deletion empty/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": "@tsconfig/node18/tsconfig.json",
"extends": "@tsconfig/node22/tsconfig.json",
"version": "5.6.3",
"compilerOptions": {
"lib": ["es2021"],
Expand Down
2 changes: 1 addition & 1 deletion encryption/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"yargs": "^16.2.0"
},
"devDependencies": {
"@tsconfig/node18": "^18.2.4",
"@tsconfig/node22": "^22.0.0",
"@types/cors": "^2.8.12",
"@types/ejson": "^2.1.3",
"@types/express": "^4.17.13",
Expand Down
2 changes: 1 addition & 1 deletion encryption/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": "@tsconfig/node18/tsconfig.json",
"extends": "@tsconfig/node22/tsconfig.json",
"version": "5.6.3",
"compilerOptions": {
"lib": ["es2021"],
Expand Down
2 changes: 1 addition & 1 deletion env-config/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"@temporalio/envconfig": "^1.15.0"
},
"devDependencies": {
"@tsconfig/node18": "^18.2.4",
"@tsconfig/node22": "^22.0.0",
"@types/node": "^22.9.1",
"@typescript-eslint/eslint-plugin": "^8.18.0",
"@typescript-eslint/parser": "^8.18.0",
Expand Down
2 changes: 1 addition & 1 deletion env-config/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": "@tsconfig/node18/tsconfig.json",
"extends": "@tsconfig/node22/tsconfig.json",
"version": "5.6.3",
"compilerOptions": {
"lib": ["es2021"],
Expand Down
2 changes: 1 addition & 1 deletion expense/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
"uuid": "8.3.2"
},
"devDependencies": {
"@tsconfig/node18": "^18.2.4",
"@tsconfig/node22": "^22.0.0",
"@types/express": "4.17.13",
"@types/node": "^22.9.1",
"@types/uuid": "8.3.1",
Expand Down
2 changes: 1 addition & 1 deletion expense/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": "@tsconfig/node18/tsconfig.json",
"extends": "@tsconfig/node22/tsconfig.json",
"version": "5.6.3",
"compilerOptions": {
"lib": ["es2021"],
Expand Down
2 changes: 1 addition & 1 deletion fetch-esm/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"node-fetch": "^3.3.2"
},
"devDependencies": {
"@tsconfig/node18": "^18.2.4",
"@tsconfig/node22": "^22.0.0",
"@types/node": "^22.9.1",
"@typescript-eslint/eslint-plugin": "^8.18.0",
"@typescript-eslint/parser": "^8.18.0",
Expand Down
2 changes: 1 addition & 1 deletion fetch-esm/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": "@tsconfig/node18/tsconfig.json",
"extends": "@tsconfig/node22/tsconfig.json",
"version": "5.6.3",
"compilerOptions": {
"lib": ["es2021"],
Expand Down
2 changes: 1 addition & 1 deletion grpc-calls/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"nanoid": "3.x"
},
"devDependencies": {
"@tsconfig/node18": "^18.2.4",
"@tsconfig/node22": "^22.0.0",
"@types/node": "^22.9.1",
"@typescript-eslint/eslint-plugin": "^8.18.0",
"@typescript-eslint/parser": "^8.18.0",
Expand Down
2 changes: 1 addition & 1 deletion grpc-calls/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": "@tsconfig/node18/tsconfig.json",
"extends": "@tsconfig/node22/tsconfig.json",
"version": "5.6.3",
"compilerOptions": {
"lib": ["es2021"],
Expand Down
2 changes: 1 addition & 1 deletion hello-world-mtls/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"@temporalio/workflow": "^1.15.0"
},
"devDependencies": {
"@tsconfig/node18": "^18.2.4",
"@tsconfig/node22": "^22.0.0",
"@types/node": "^22.9.1",
"@typescript-eslint/eslint-plugin": "^8.18.0",
"@typescript-eslint/parser": "^8.18.0",
Expand Down
2 changes: 1 addition & 1 deletion hello-world-mtls/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": "@tsconfig/node18/tsconfig.json",
"extends": "@tsconfig/node22/tsconfig.json",
"version": "5.6.3",
"compilerOptions": {
"lib": ["es2021"],
Expand Down
2 changes: 1 addition & 1 deletion hello-world/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
},
"devDependencies": {
"@temporalio/testing": "^1.15.0",
"@tsconfig/node18": "^18.2.4",
"@tsconfig/node22": "^22.0.0",
"@types/mocha": "8.x",
"@types/node": "^22.9.1",
"@typescript-eslint/eslint-plugin": "^8.18.0",
Expand Down
2 changes: 1 addition & 1 deletion hello-world/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": "@tsconfig/node18/tsconfig.json",
"extends": "@tsconfig/node22/tsconfig.json",
"version": "5.6.3",
"compilerOptions": {
"lib": ["es2021"],
Expand Down
2 changes: 1 addition & 1 deletion interceptors-opentelemetry/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
"@temporalio/workflow": "^1.15.0"
},
"devDependencies": {
"@tsconfig/node18": "^18.2.4",
"@tsconfig/node22": "^22.0.0",
"@types/node": "^22.9.1",
"@typescript-eslint/eslint-plugin": "^8.18.0",
"@typescript-eslint/parser": "^8.18.0",
Expand Down
4 changes: 2 additions & 2 deletions interceptors-opentelemetry/src/instrumentation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

/* eslint-disable @typescript-eslint/no-unused-vars */
import { NodeSDK } from '@opentelemetry/sdk-node';
import { ConsoleSpanExporter, SimpleSpanProcessor, SpanProcessor, SpanExporter } from '@opentelemetry/sdk-trace-node';
import { ConsoleSpanExporter, SpanProcessor, SpanExporter, BatchSpanProcessor } from '@opentelemetry/sdk-trace-node';
import { OTLPTraceExporter as OTLPTraceExporterGrpc } from '@opentelemetry/exporter-trace-otlp-grpc';
import { OTLPTraceExporter as OTLPTraceExporterHttp } from '@opentelemetry/exporter-trace-otlp-http';
import { OTLPMetricExporter as OTLPMetricExporterGrpc } from '@opentelemetry/exporter-metrics-otlp-grpc';
Expand Down Expand Up @@ -118,7 +118,7 @@ export const resource = new Resource({
const traceExporter = setupTraceExporter();

export const spanProcessor: SpanProcessor | undefined = traceExporter
? new SimpleSpanProcessor(traceExporter)
? new BatchSpanProcessor(traceExporter)
: undefined;

const metricReader = setupMetricReader();
Expand Down
3 changes: 3 additions & 0 deletions interceptors-opentelemetry/src/worker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,9 @@ async function main() {
workflowsPath: require.resolve('./workflows'),
activities,
taskQueue: 'interceptors-opentelemetry-example',
// IMPORTANT: When prebundling Workflow code (i.e. using `bundleWorkflowCode(...)`), you MUST
// provide the following `plugins` property to `bundleWorkflowCode()`.
// Workflow code tracing won't work if you don't.
plugins,
});
try {
Expand Down
2 changes: 1 addition & 1 deletion interceptors-opentelemetry/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": "@tsconfig/node18/tsconfig.json",
"extends": "@tsconfig/node22/tsconfig.json",
"version": "5.6.3",
"compilerOptions": {
"lib": ["es2021"],
Expand Down
2 changes: 1 addition & 1 deletion message-passing/execute-update/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
},
"devDependencies": {
"@temporalio/testing": "^1.15.0",
"@tsconfig/node18": "^18.2.4",
"@tsconfig/node22": "^22.0.0",
"@types/mocha": "8.x",
"@types/node": "^22.9.1",
"@typescript-eslint/eslint-plugin": "^8.18.0",
Expand Down
2 changes: 1 addition & 1 deletion message-passing/execute-update/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": "@tsconfig/node18/tsconfig.json",
"extends": "@tsconfig/node22/tsconfig.json",
"version": "5.6.3",
"compilerOptions": {
"lib": ["es2021"],
Expand Down
2 changes: 1 addition & 1 deletion message-passing/introduction/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
},
"devDependencies": {
"@temporalio/testing": "^1.15.0",
"@tsconfig/node18": "^18.2.4",
"@tsconfig/node22": "^22.0.0",
"@types/mocha": "8.x",
"@types/node": "^22.9.1",
"@typescript-eslint/eslint-plugin": "^8.18.0",
Expand Down
Loading