-
Notifications
You must be signed in to change notification settings - Fork 94
Update Python SDK to 1.20.0 #264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
VegetarianOrc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but let's take this opportunity to fix the CI pipeline as well.
Would you mind updating the tests to run python 3.10 & 3.14 and update the macos targets to use macos-15-intel and macos-latest like the SDK does?
| config = ClientConfig.load_client_connect_config() | ||
| config.setdefault("target_host", "localhost:7233") | ||
| config.setdefault("namespace", NAMESPACE), | ||
| (config.setdefault("namespace", NAMESPACE),) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably harmless, but the new formatter highlights the trailing comma.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that looks gnarly, fixed up
What was changed
blacktoruffto mirror SDK lib for lintingWhy?
new release
Checklist
Closes
How was this tested: