Skip to content

Fix clusterIP: None in example helm chart. #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
anstoli wants to merge 1 commit into from
Closed

Fix clusterIP: None in example helm chart. #194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions charts/s2s-proxy/example.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ metadata:
app.kubernetes.io/managed-by: Helm
spec:
type: ClusterIP
clusterIP: None
ports:
- port: 9233
targetPort: 9233
Expand Down
3 changes: 3 additions & 0 deletions charts/s2s-proxy/templates/service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ metadata:
{{- include "s2s-proxy.labels" . | nindent 4 }}
spec:
type: {{ .Values.service.type }}
{{- if .Values.service.clusterIP }}
clusterIP: {{ .Values.service.clusterIP }}
{{- end }}
ports:
{{- $ports := (include "s2s-proxy.parsedPorts" . | fromYaml) }}
- port: {{ $ports.egress }}
Expand Down
2 changes: 1 addition & 1 deletion charts/s2s-proxy/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ service:
type: ClusterIP
# We strongly recommend using a headless service. Temporal uses gRPC internally, and kube-proxy's routing conflicts with
# gRPC's client-side load balancer. More info https://kubernetes.io/docs/concepts/services-networking/service/#headless-services
ClusterIP: None
clusterIP: None

# We recommend a minimum of 4 CPUs, 512Mi for your proxy as a good starting point.
# If you have a larger dataset (>5RPS steady-state traffic, >10GB history size), a larger proxy deployment may be necessary
Expand Down