Non retryable errors for activities course port #4046
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📖 Docs PR preview links
|
jsundai
changed the title
| In most cases, we recommend using the Workflow Execution Timeout for [Workflows](/workflows) or the Schedule-To-Close Timeout for Activities to limit the total duration of retries, rather than using this attribute. | ||
|
|
||
| ### Non-Retryable Errors | ||
| ### Non-Retryable Errors {#non-retryable-errors} |
There was a problem hiding this comment.
Just something I've been wondering about. Why do we do the {#....} on some of the headings?
|
|
||
| To raise a non-retryable error, specify the `non_retryable` flag when raising an `ApplicationError`: | ||
|
|
||
| ```python |
There was a problem hiding this comment.
The spacing looks a little off here. I think if you remove the spaces to the left, it'll line up with the code block.
|
|
||
| To throw a non-retryable error, use the `newNonRetryableFailure` method: | ||
|
|
||
| ```java |
There was a problem hiding this comment.
The spacing looks a little off here. I think if you remove the spaces to the left, it'll line up with the code block.
| throw new ApplicationFailureException( | ||
| $"Something bad happened on attempt {attempt}", | ||
| errorType: "my_failure_type", | ||
| nonRetryable: true); |
There was a problem hiding this comment.
| nonRetryable: true); | |
| nonRetryable: true | |
| ); |
There was a problem hiding this comment.
Just a suggestion to make that closing parentheses clearer.
| --- | ||
|
|
||
| import { CaptionedImage, RelatedReadContainer, RelatedReadItem } from '@site/src/components'; | ||
| import Tabs from '@theme/Tabs'; |
There was a problem hiding this comment.
Just a question, but why are we using the <Tabs> instead of the <SdkTabs>?
Co-authored-by: Milecia McG <47196133+flippedcoder@users.noreply.github.com>
What does this PR do?
port from errors course for all languages given. added to retry policy page.
code samples language ports:
Notes to reviewers