feat: visual comparison CI workflow #3884
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![semgrep-managed-scans[bot]](https://avatars.githubusercontent.com/u/56493103?s=60&v=4){kind=small}
lennessyy
changed the title
Contributor
📖 Docs PR preview linksThis PR does not change any pages in /docs. If you make updates, links to the modified pages will appear here. |
|
Semgrep found 9
No explicit |
Add explicit permissions blocks to all jobs in the visual comparison workflows to address Semgrep security findings. Following least-privilege principle: - visual-comparison.yml: Added permissions for contents, actions, and pull-requests - screenshot-capture.yml: Added permissions for contents and actions - cleanup-report.yml: Added permissions for contents write 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Move all GitHub context variables in run steps to environment variables to prevent script injection attacks. This addresses Semgrep findings for: - visual-comparison.yml: github.base_ref, github.head_ref, github.ref_name, github.run_id, github.run_attempt - cleanup-report.yml: github.event.ref Branch names and other GitHub context data can contain special characters that could lead to command injection when directly interpolated in bash. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Change trigger label from 'visual-tests' to 'visual-comparison' - Remove branches-ignore for version-* and docs-rel-* (not applicable to this repo) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
lennessyy
added
visual-comparison
lennessyy
added
visual-comparison
Remove @playwright/test from dependencies to resolve conflict with devDependencies. Playwright is a testing tool and should only be in devDependencies (^1.55.1). This fixes the "Your lockfile needs to be updated" error in CI. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Add step to automatically create the gh-pages branch when it doesn't exist, allowing the workflow to publish HTML reports on first run. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Check if gh-pages branch exists before attempting checkout or creation. This avoids the git state issues that were causing the previous approach to fail. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Move git config step before the commit to avoid "empty ident name" error. Also set git user for both the creation and existing branch paths. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Use `git push -u origin gh-pages` when creating the branch - Use explicit `origin gh-pages` in pull/push commands to avoid tracking issues This fixes the "no tracking information for the current branch" error. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Make branch creation non-failing if branch already exists (race condition) - Always checkout gh-pages after creation attempt, simplifying the flow - Set git user once for all cases The gh-pages branch now exists, so future runs will skip creation. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Contributor
|
📋 Visual Report for branch visual-comparison with CI run 20446936180 and attempt 1 is ready at 💡 You may have to wait for DNS to resolve or the GitHub Pages job to complete. You can view the progress of the GitHub Pages job here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Notes to reviewers