Skip to content

Commit bf63d75

Browse files
committed
Simplify test: use invalid host instead of socket dance
1 parent 90f17ef commit bf63d75

1 file changed

Lines changed: 2 additions & 7 deletions

File tree

internal/temporalcli/commands_test.go

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ import (
66
"fmt"
77
"io"
88
"log/slog"
9-
"net"
109
"regexp"
1110
"slices"
1211
"strings"
@@ -632,19 +631,15 @@ func TestErrorReporting_IndependentOfLogLevel(t *testing.T) {
632631
for _, logLevel := range []string{"never", "error", "info"} {
633632
t.Run("log-level="+logLevel, func(t *testing.T) {
634633
h := NewCommandHarness(t)
635-
ln, err := net.Listen("tcp", "127.0.0.1:0")
636-
require.NoError(t, err)
637-
ln.Close() // close immediately so connection is refused
638-
639634
res := h.Execute(
640635
"workflow", "list",
641-
"--address", ln.Addr().String(),
636+
"--address", "not-a-valid-host:1",
642637
"--log-level", logLevel,
643638
)
644639
require.Error(t, res.Err)
645640

646641
stderr := res.Stderr.String()
647-
assert.NotContains(t, stderr, "level=ERROR",
642+
assert.NotContains(t, stderr, "level=",
648643
"errors should not appear as structured log messages on stderr")
649644
})
650645
}

0 commit comments

Comments
 (0)