Skip to content

Commit 90f17ef

Browse files
committed
Add comment documenting no-logging discipline
1 parent f08ca48 commit 90f17ef

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

internal/temporalcli/commands.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,9 @@ type CommandContext struct {
4848
FlagsWithEnvVars []*pflag.Flag
4949

5050
// These values may not be available until after pre-run of main command
51-
Printer *printer.Printer
51+
Printer *printer.Printer
52+
// The logger is for the SDK and server. The CLI itself should print warnings or errors to
53+
// stderr but should not use logging.
5254
Logger *slog.Logger
5355
JSONOutput bool
5456
JSONShorthandPayloads bool

0 commit comments

Comments
 (0)