[don't merge] time skipping sleep: need review and server PR#786
Open
feiyang3cat wants to merge 1 commit into
Open
[don't merge] time skipping sleep: need review and server PR#786feiyang3cat wants to merge 1 commit into
feiyang3cat wants to merge 1 commit into
Conversation
64911c4 to
f733324
Compare
7431f2f to
e24f538
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
boundtosleep timerto match the previous semantics exposed by the SDK Testing serverdisable_propagation_for_childto give users a way to stop propagationWhy?
sleepis a simpler and cleaner concept thanboundfor user experience and backward compatibilityBreaking changes
maxSkippedDuration-> the server has already implemented this feature need to delete the code firstmaxElapsedDurationtosleep-> the server need to do renamingServer PR
TBD