Skip to content

[don't merge] time skipping sleep: need review and server PR#786

Open
feiyang3cat wants to merge 1 commit into
masterfrom
patch/ts
Open

[don't merge] time skipping sleep: need review and server PR#786
feiyang3cat wants to merge 1 commit into
masterfrom
patch/ts

Conversation

@feiyang3cat
Copy link
Copy Markdown
Contributor

@feiyang3cat feiyang3cat commented May 22, 2026

What changed?

  1. Removed obsolete fields — safe to delete as this feature has not been released (disable compatibility checking temporarily)
  2. Renamed bound to sleep timer to match the previous semantics exposed by the SDK Testing server
  3. Add disable_propagation_for_child to give users a way to stop propagation

Why?

  1. for 1) make the API cleaner
  2. for 2) simplify user experience
  • sleep is a simpler and cleaner concept than bound for user experience and backward compatibility
  1. for 3) a child workflow is a different execution and has its own virtual clock, and users may need an option to change the default propagation behavior

Breaking changes

  1. removed the feature maxSkippedDuration-> the server has already implemented this feature need to delete the code first
  2. restructured the maxElapsedDurationto sleep-> the server need to do renaming

Server PR
TBD

@feiyang3cat feiyang3cat requested review from a team May 22, 2026 22:14
@feiyang3cat feiyang3cat force-pushed the patch/ts branch 3 times, most recently from 64911c4 to f733324 Compare May 22, 2026 22:42
@feiyang3cat feiyang3cat force-pushed the patch/ts branch 2 times, most recently from 7431f2f to e24f538 Compare June 1, 2026 02:13
@feiyang3cat feiyang3cat changed the title [don't merge] just for review [don't merge] need review and server PR Jun 1, 2026
@feiyang3cat feiyang3cat changed the title [don't merge] need review and server PR [don't merge] time skipping sleep: need review and server PR Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant