Conversation
| message TimeSkippingConfig { | ||
|
|
||
| // If set, enables automatic time-skipping for this workflow execution. | ||
| // It can also be disabled by setting this field to false. |
There was a problem hiding this comment.
@Sushisource Hey! I've cleaned this pr and ready for review.
And this config may need special attention since it is changed significantly from previous version Chad proposed.
(1)deleted most of the fine-grained control (like max timer-firing count, max duration to skip) from the previous version. The reason is it is ambiguous when complicated configuration is propagated to child-workflows.
(2) I have also changed the nested config to one single layer because this configuration is only used for automatic time-skipping, manual time-skipping will have a separate request and response payload
(3) we allow disabling time-skipping for in-flight workflows since it is not hard for the server to have this feature, and it will be a nice-to-have feature same as the SDK TestServer.
I think we can consider wrapping up this pr early, and put manual time-skipping in a separate pr maybe.
Pls feel free to disagree, happy to refine.
feiyang3cat
force-pushed
the
api-time-skipping-v2
branch
2 times, most recently
from
500a020 to
83f6639
Compare
feiyang3cat
force-pushed
the
api-time-skipping-v2
branch
from
83f6639 to
e1e1c03
Compare
1 participant
What changed?
new feature: automatic time-skipping configuration and new event type added
Breaking changes
new event type added but right now no workflow history will have this new event type
Server PR
not expect to break server, no new rpc-handler and new fields are all optional