Skip to content

fix(discovery): handle the discovery test case corectlly #1839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
innocenzi merged 3 commits into from
Dec 30, 2025
+7 −8
Merged

fix(discovery): handle the discovery test case corectlly #1839

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0c43964
fix(discovery): handle the discovery test case corectlly
MohammadAlhallaq Dec 29, 2025
33936d7
fix: code formatting
MohammadAlhallaq Dec 30, 2025
e243f1e
refactor: minor clean up
innocenzi Dec 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions tests/Integration/Core/LoadDiscoveryClassesTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
use Tempest\Database\MigratesUp;
use Tempest\Database\Migrations\RunnableMigrations;
use Tempest\Discovery\DiscoveryLocation;
use Tempest\Support\Arr;
use Tests\Tempest\Fixtures\Discovery\HiddenDatabaseMigration;
use Tests\Tempest\Fixtures\Discovery\HiddenMigratableDatabaseMigration;
use Tests\Tempest\Fixtures\GlobalHiddenDiscovery;
Expand All @@ -17,8 +18,6 @@
use Tests\Tempest\Integration\Core\Fixtures\ManualTestDiscoveryDependency;
use Tests\Tempest\Integration\FrameworkIntegrationTestCase;

use function Tempest\get;

/**
* @internal
*/
Expand All @@ -27,9 +26,9 @@ final class LoadDiscoveryClassesTest extends FrameworkIntegrationTestCase
#[Test]
public function do_not_discover(): void
{
$migrations = get(RunnableMigrations::class);
$migrations = $this->container->get(RunnableMigrations::class);

$this->assertNotContains(HiddenDatabaseMigration::class, $migrations);
$this->assertFalse(Arr\contains($migrations, fn ($m) => $m instanceof HiddenDatabaseMigration));
}

#[Test]
Expand All @@ -47,11 +46,11 @@ public function do_not_discover_global_path(): void
#[Test]
public function do_not_discover_except(): void
{
$migrations = get(RunnableMigrations::class);
$migrations = $this->container->get(RunnableMigrations::class);

$foundMigrations = array_filter(
iterator_to_array($migrations),
static fn (MigratesUp $migration) => $migration instanceof HiddenMigratableDatabaseMigration,
$foundMigrations = Arr\filter(
array: iterator_to_array($migrations),
filter: static fn (MigratesUp $migration) => $migration instanceof HiddenMigratableDatabaseMigration,
);

$this->assertCount(1, $foundMigrations, 'Expected one hidden migration to be found');
Expand Down