Skip to content

generate getters and setters consistently with qnames #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mikesamuel wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

generate getters and setters consistently with qnames #451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 51 additions & 10 deletions be/src/commonTest/kotlin/lang/temper/be/tmpl/TmpLBackendTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -724,10 +724,10 @@ class TmpLBackendTest {
/* this */ this__1.prop__4 = prop__6;
return;
}
@reach(\none) get.prop -> getprop__8(this = this__9, @impliedThis(C__0) this__9: C__0): Int32 {
@QName("test-library/C.type C.get prop()") @reach(\none) get.prop -> getprop__8(this = this__9, @QName("test-library/C.type C.get prop().(this)") @impliedThis(C__0) this__9: C__0): Int32 {
return /* this */ this__9.prop__4;
}
@reach(\none) set.prop -> setprop__11(this = this__13, @impliedThis(C__0) this__13: C__0, newProp__12: Int32): Void {
@QName("test-library/C.type C.set prop()") @reach(\none) set.prop -> setprop__11(this = this__13, @QName("test-library/C.type C.set prop().(this)") @impliedThis(C__0) this__13: C__0, @QName("test-library/C.type C.set prop().(newProp)") newProp__12: Int32): Void {
/* this */ this__13.prop__4 = newProp__12;
return;
}
Expand Down Expand Up @@ -1258,7 +1258,7 @@ class TmpLBackendTest {
| /* this */ this__2.x__0 = x__1;
| return;
| }
| get.x -> getx__0(this = this__3, @impliedThis(C) this__3: C): Int32 {
| @QName("test-library/myClass.type C.get x()") get.x -> getx__0(this = this__3, @QName("test-library/myClass.type C.get x().(this)") @impliedThis(C) this__3: C): Int32 {
| return /* this */ this__3.x__0;
| }
| }
Expand Down Expand Up @@ -1320,9 +1320,12 @@ class TmpLBackendTest {
| //// work//aType/ => aType.tmpl
| require temper-core;
| let InterfaceTypeSupport#0 = InterfaceTypeSupport;
| let pureVirtual#0 = builtins.pureVirtual;
| @QName("test-library/aType.type I") interface I / I {
| @QName("test-library/aType.type I.x") let x__0: String;
| get.x -> nym`get.x#0`(this = this#0, this#0: I): String;
| @QName("test-library/aType.type I.get x()") get.x -> getx__0(this = this__0, @QName("test-library/aType.type I.get x().(this)") @impliedThis(I) this__0: I): String {
| pureVirtual#0();
| }
| }
|
| ```
Expand Down Expand Up @@ -1465,10 +1468,10 @@ class TmpLBackendTest {
| /* this */ this__0.p__0 = p__1;
| return;
| }
| get.p -> getp__0(this = this__1, @impliedThis(C__0) this__1: C__0): Int32 {
| @QName("test-library/foo.type C.get p()") get.p -> getp__0(this = this__1, @QName("test-library/foo.type C.get p().(this)") @impliedThis(C__0) this__1: C__0): Int32 {
| return /* this */ this__1.p__0;
| }
| set.p -> setp__0(this = this__2, @impliedThis(C__0) this__2: C__0, newP__0: Int32): Void {
| @QName("test-library/foo.type C.set p()") set.p -> setp__0(this = this__2, @QName("test-library/foo.type C.set p().(this)") @impliedThis(C__0) this__2: C__0, @QName("test-library/foo.type C.set p().(newP)") newP__0: Int32): Void {
| /* this */ this__2.p__0 = newP__0;
| return;
| }
Expand Down Expand Up @@ -1664,7 +1667,7 @@ class TmpLBackendTest {
| /* this */ this__0.x__0 = x__1;
| return;
| }
| get.x -> getx__0(this = this__1, @impliedThis(Point) this__1: Point): Int32 {
| @QName("test-library/foo.type Point.get x()") get.x -> getx__0(this = this__1, @QName("test-library/foo.type Point.get x().(this)") @impliedThis(Point) this__1: Point): Int32 {
| return /* this */ this__1.x__0;
| }
| }
Expand Down Expand Up @@ -2029,7 +2032,7 @@ class TmpLBackendTest {
| /* this */ this__0.a__0 = a__2;
| return;
| }
| get.a -> geta__0(this = this__1, @impliedThis(A) this__1: A): String {
| @QName("test-library/foo.type A.get a()") get.a -> geta__0(this = this__1, @QName("test-library/foo.type A.get a().(this)") @impliedThis(A) this__1: A): String {
| return /* this */ this__1.a__0;
| }
| }
Expand Down Expand Up @@ -3015,7 +3018,7 @@ class TmpLBackendTest {
| ConsoleLog#0(console#0, "Made C");
| return;
| }
| get.s -> gets__0(this = this__1, @impliedThis(C__0) this__1: C__0): String {
| @QName("test-library/foo.type C.get s()") get.s -> gets__0(this = this__1, @QName("test-library/foo.type C.get s().(this)") @impliedThis(C__0) this__1: C__0): String {
| return /* this */ this__1.s__0;
| }
| }
Expand Down Expand Up @@ -3727,7 +3730,7 @@ class TmpLBackendTest {
| /* this */ this__0.s__0 = s__1;
| return;
| }
| get.s -> gets__0(this = this__1, @impliedThis(StringBoxes) this__1: StringBoxes): String {
| @QName("test-library/foo.type StringBoxes.get s()") get.s -> gets__0(this = this__1, @QName("test-library/foo.type StringBoxes.get s().(this)") @impliedThis(StringBoxes) this__1: StringBoxes): String {
| return /* this */ this__1.s__0;
| }
| }
Expand Down Expand Up @@ -3895,6 +3898,44 @@ class TmpLBackendTest {
""".trimMargin(),
)

@Test
fun interfaceWithAbstractProperty() = assertGeneratedCode(
inputFileMapFromJson(
"""
|{
| foo.temper:
| ```
| export interface I {
| b: Boolean;
| }
| ```
|}
""".trimMargin(),
),
want = """
|{
| tmpl: {
| test_library.tmpl: {
| content: ```
| //// work// => test_library.tmpl
| require temper-core;
| let InterfaceTypeSupport#0 = InterfaceTypeSupport;
| let pureVirtual#0 = builtins.pureVirtual;
| @QName("test-library.type I") interface I / I {
| @QName("test-library.type I.b") let b__0: Boolean;
| @QName("test-library.type I.get b()") get.b -> getb__0(this = this__0, @QName("test-library.type I.get b().(this)") @impliedThis(I) this__0: I): Boolean {
| pureVirtual#0();
| }
| }
|
| ```,
| },
| test_library.tmpl.map: "__DO_NOT_CARE__"
| }
|}
""".trimMargin(),
)

@Ignore // Not yet implemented
@Test
fun staticInitializersInitializedAfterTypeDeclared() = assertGeneratedCode(
Expand Down
11 changes: 10 additions & 1 deletion frontend/src/commonMain/kotlin/lang/temper/frontend/define/DefineStage.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import lang.temper.frontend.flipDeclaredNames
import lang.temper.frontend.interpretiveDanceStage
import lang.temper.frontend.json.mixinJsonInterop
import lang.temper.frontend.syntax.DotOperationDesugarer
import lang.temper.frontend.syntax.fillInMissingQnameMetadata
import lang.temper.log.Debug
import lang.temper.log.FailLog
import lang.temper.log.LogSink
Expand All @@ -31,7 +32,7 @@ internal class DefineStage(
fun process(callback: (outputs: StageOutputs) -> Unit) {
val configKey = root.configurationKey
var addTemperTestInstructions = false
val outputs = Debug.Frontend.DefineStage(configKey).group("Debug stage") {
val outputs = Debug.Frontend.DefineStage(configKey).group("Define Stage") {
interpretiveDanceStage(
stage = Stage.Define,
root = root,
Expand Down Expand Up @@ -98,6 +99,14 @@ internal class DefineStage(
.snapshot(configKey, AstSnapshotKey, root)
}

Debug.Frontend.DefineStage.FillInMissingQNames(configKey)

@mikesamuel mikesamuel Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just make sure there're qnames on anything that was added since.

.benchmarkIf(BENCHMARK, "FillInMissingQNames") {
fillInMissingQnameMetadata(root)
}

Debug.Frontend.DefineStage.AfterFillInMissingQNames
.snapshot(configKey, AstSnapshotKey, root)

Debug.Frontend.DefineStage.SimplifyDeclarations(configKey)
.benchmarkIf(BENCHMARK, "SimplifyDeclarations") {
SimplifyDeclarations().simplify(root)
Expand Down
Loading
Loading