fix: Add check for own address in SwitchReporter#1002
Draft
SillyZir wants to merge 1 commit intotellor-io:mainfrom
Draft
fix: Add check for own address in SwitchReporter#1002SillyZir wants to merge 1 commit intotellor-io:mainfrom
SillyZir wants to merge 1 commit intotellor-io:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added a validation check in
SwitchReporterto prevent a reporter from switching to their own address, which previously caused the reporter to be incorrectly removed from the Reporter store.Fixes #991
Problem
When a reporter called
SwitchReporterwith their own address as the destination (self-to-self switch), the function would proceed without error but remove the reporter from the store entirely, effectively deleting their registration instead of blocking the invalid operation.Solution
Added an early validation check in
types/global.gothat compares the caller's address against the target address and returns anerrors.Newerror if they match, blocking the self-switch before any store mutations occur. The"cosmossdk.io/math"andsdkimports were reordered, and the"errors"package was added to support the new validation.Impact
This prevents reporters from accidentally or intentionally deregistering themselves through a self-referential switch, preserving data integrity in the Reporter store and closing a potential griefing vector.