Adds a withdraw delay bypass list for vaults such as Yearn #233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When users own pools shares THROUGH a middleman vault such as a Yearn Vault, the fact that there is a delay on shares withdraw means that there is a DDOS attack vector whereby a exploiter can 'withdraw' from the yearn vault every 5 minutes to prevent other users from withdrawing their shares via Yearn.
This is because the pool tracks shares by account and is unable to track them by-account-by-sub-account such as in the case of a Yearn Vault which has sub-accounts to itself.
Therefore one good solution is to allow ProtocolOwner to flag the Yearn Vault address as not needing any withdraw delay. This should only be set on acccounts which have their own separate MEV protection, such as a standard Yearn vault.