-
Notifications
You must be signed in to change notification settings - Fork 68
chore: update next.js demo and resolve issue in result of recent nextjs version upgrade #347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the Next.js Telerik Reporting demo to resolve compatibility issues introduced by recent Next.js version upgrades. The changes implement dynamic imports with SSR disabled for the Telerik Report Viewer component and update the Kendo UI theme CDN links to the latest version.
Key Changes:
- Implemented dynamic import with SSR disabled for the TelerikReportViewer component to ensure client-side-only rendering
- Updated Kendo UI theme CDN links from version 2022.3.913 to themes/12.0.0 with the classic-opal theme
- Upgraded @progress/telerik-react-report-viewer package from version ^24.24.1218 to ^28.25.1119
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| nextjs-telerik-rv-example/src/app/page.js | Implements dynamic import for TelerikReportViewer with SSR disabled and updates Kendo UI theme CDN references |
| nextjs-telerik-rv-example/package.json | Updates telerik-react-report-viewer dependency to version ^28.25.1119 |
Files not reviewed (1)
- nextjs-telerik-rv-example/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.
Files not reviewed (1)
- nextjs-telerik-rv-example/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Our example is not really compatible with https://demos.telerik.com/reporting/api/reports/ as of now, since the demos REST service relies on version That said, I tested with a local |
| import { TelerikReportViewer } from '@progress/telerik-react-report-viewer' | ||
| import dynamic from 'next/dynamic' | ||
|
|
||
| const TelerikReportViewer = dynamic(() => import('@progress/telerik-react-report-viewer') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no idea what does this line do :)
ighristov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing it, Pepi!

refs #344