fix: resolve empty canvas when drilling into called workflow from popup#4
Merged
Conversation
Clicking a 'uses:' link in the orchestrator popup passed a JobData to
drillInto(), which assumed OrchestratorData at orchestrator level and
set orchestratorId to the job key — causing resolveActiveWorkflow to
return null and rendering an empty canvas.
Fix: distinguish OrchestratorData ('calledWorkflows' in item) from
JobData ('uses' in item) in the orchestrator branch, and resolve the
reusable workflow directly via resolveUsesRef.
* Bumped version from `1.0.2` to `1.0.3` in both `package.json` and `package-lock.json`. * Updated dependencies to their latest versions for improved stability and performance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
uses:link in the orchestrator popup's "Calls" section navigated to an empty canvasdrillInto()assumeditemis alwaysOrchestratorDataat orchestrator level, but the popup passes a minimalJobData— causingorchestratorIdto be set to the job key (e.g.lint), whichresolveActiveWorkflowcouldn't match'calledWorkflows' in itemto distinguishOrchestratorDatafromJobData; forJobDatawithuses:, resolve the target workflow directly viaresolveUsesRefand navigate to its job levelTest plan