Add RISC-V support#29
Open
peeweep wants to merge 1 commit into
Open
Conversation
1 task
thrix
requested changes
Jun 24, 2026
|
|
||
| # RISC-V image not released | ||
| if arch == "riscv64": | ||
| return "https://dl.fedoraproject.org/pub/alt/risc-v/release/42/Cloud/riscv64/images/Fedora-Cloud-Base-Generic-42.20250911-2251ba41cdd3.riscv64.qcow2" |
Contributor
There was a problem hiding this comment.
@peeweep isn't there a way to not hardcode the URL here, at least find the latest image somehow or similar?
| DEBIAN_RELEASE_MAP = {"10": "buster", "11": "bullseye", "12": "bookworm"} | ||
| DEBIAN_LATEST = "12" | ||
| DEBIAN_RELEASE_MAP = {"10": "buster", "11": "bullseye", "12": "bookworm", "13": "trixie"} | ||
| DEBIAN_LATEST = "13" |
Contributor
There was a problem hiding this comment.
I consider this change unexpected to the RISC-V support. Please update the MR description with the reason for this change.
|
|
||
| def get_debian_image_url(version: str, arch: str) -> str: | ||
| arch_map = {"x86_64": "amd64", "aarch64": "arm64", "ppc64le": "ppc64el"} | ||
| arch_map = {"x86_64": "amd64", "aarch64": "arm64", "ppc64le": "ppc64el", "riscv64": "riscv64"} |
Contributor
There was a problem hiding this comment.
README.md should be updated also
| cpu=( | ||
| "<cpu mode='host-passthrough' check='none'/>" | ||
| if self.kvm | ||
| else "<cpu mode='custom' match='exact'><model>rva23s64</model></cpu>" |
Contributor
There was a problem hiding this comment.
Would it make sense to be more conservative here? e.g. use rather rv64 ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.