Skip to content

Conversation

@skoudoro
Copy link
Collaborator

@skoudoro skoudoro commented Feb 6, 2026

fix #84

Small PR to add trx info myfile.trx CLI

image

@skoudoro skoudoro requested a review from arokem February 6, 2026 18:16
@codecov
Copy link

codecov bot commented Feb 6, 2026

Codecov Report

❌ Patch coverage is 94.93671% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.75%. Comparing base (6b4a53d) to head (5f61255).
⚠️ Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
trx/trx_file_memmap.py 75.00% 3 Missing ⚠️
trx/cli.py 97.61% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #105      +/-   ##
==========================================
+ Coverage   59.95%   61.75%   +1.79%     
==========================================
  Files          13       13              
  Lines        2462     2536      +74     
==========================================
+ Hits         1476     1566      +90     
+ Misses        986      970      -16     
Flag Coverage Δ
unittests 61.75% <94.93%> (+1.79%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@skoudoro
Copy link
Collaborator Author

skoudoro commented Feb 9, 2026

Can I go ahead and merge @arokem or @frheault ?

@arokem
Copy link
Collaborator

arokem commented Feb 9, 2026

Small nit, but do we want to print something more informative for cases where some item is not there. For example, something like:

No group keys 

When no group keys are encoded?

@skoudoro
Copy link
Collaborator Author

skoudoro commented Feb 9, 2026

Thanks for the feedback @arokem.

added here: e839036

@skoudoro
Copy link
Collaborator Author

skoudoro commented Feb 9, 2026

The doc build fails and it is expected. See nipy/nibabel#1463

@arokem
Copy link
Collaborator

arokem commented Feb 9, 2026

LGTM! Thanks for making this!

@arokem arokem merged commit f436d76 into tee-ar-ex:master Feb 9, 2026
16 checks passed
@skoudoro skoudoro deleted the trx-info branch February 10, 2026 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CLI that shows the contents of a TRX

2 participants