Port engine_xetex to Rust#1317
Draft
CraftSpider wants to merge 61 commits intotectonic-typesetting:masterfrom
Draft
Port engine_xetex to Rust#1317CraftSpider wants to merge 61 commits intotectonic-typesetting:masterfrom
CraftSpider wants to merge 61 commits intotectonic-typesetting:masterfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1317 +/- ##
==========================================
+ Coverage 28.85% 30.07% +1.21%
==========================================
Files 273 281 +8
Lines 203491 181273 -22218
Branches 203491 181273 -22218
==========================================
- Hits 58724 54518 -4206
+ Misses 64143 54952 -9191
+ Partials 80624 71803 -8821
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CraftSpider
force-pushed
the
engine-port
branch
2 times, most recently
from
1c66d6a to
84de890
Compare
CraftSpider
force-pushed
the
engine-port
branch
from
84de890 to
4290774
Compare
CraftSpider
force-pushed
the
engine-port
branch
from
06438b6 to
11d0754
Compare
CraftSpider
force-pushed
the
engine-port
branch
from
11d0754 to
270cc6a
Compare
CraftSpider
force-pushed
the
engine-port
branch
from
08f76ad to
64795a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the big one - begin converting the engine into Rust.
CI clippy and Windows vcpkg are consistently failing. I'm leaving off fixing those till the end, as long as every other check is passing. vcpkg is a weird one in particular, it's related to a library on Windows not getting linked but that apparently works without these (non-build) changes. So I'm hoping removing most of the C code will just make it fix itself eventually.