Reraise exceptions within #request instead of continuing#35
Open
mistydemeo wants to merge 2 commits intotechnoweenie:masterfrom
Open
Reraise exceptions within #request instead of continuing#35mistydemeo wants to merge 2 commits intotechnoweenie:masterfrom
mistydemeo wants to merge 2 commits intotechnoweenie:masterfrom
Conversation
Previously, if an exception was raised in #request, the function would be allowed to continue through to returning the callback. This callback would almost certainly fail.
Collaborator
|
I'm just trying to think if there'd be any problems with having a callback getting the error, and also the error being thrown. Considering it's part of the setup, it probably makes more sense to just throw it, but I'm not sure how that'd impact consumers. |
Author
|
Updated to just throw - at that point, we don't need to catch the exception anymore. (Diff best viewed with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, if an exception was raised in #request, the function would be allowed to continue through to returning the callback. This callback would almost certainly fail. Raising here, rather than returning after calling the callback with the exception, makes more sense to me because the return value is still expected to be a function.
I ran into this when an exception was raised on the line where
reqis assigned; it went on to return the function anyway, which then failed becausereqwas never defined.cc @technicalpickles