Skip to content

Conversation

@es3n1n
Copy link

@es3n1n es3n1n commented Dec 17, 2025

#616

Blocked by techniq/layerstack#95, once its merged i'll need to bump the versions in package.json + remove extra case for get with a number

@changeset-bot
Copy link

changeset-bot bot commented Dec 17, 2025

🦋 Changeset detected

Latest commit: e3253fa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
shadcn-svelte-1 Patch
svelteux-2 Patch
skeleton-3 Patch
skeleton4 Patch
standalone Patch
layerchart Patch
daisyui-5 Patch
docs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@es3n1n es3n1n changed the title refactor: migrate from lodash to layerstack/utils Remove lodash-es dependency Dec 17, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 17, 2025

Open in StackBlitz

npm i https://pkg.pr.new/layerchart@734

commit: 017c84f

@github-actions
Copy link
Contributor

github-actions bot commented Dec 17, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
layerchart ✅ Ready (View Log) Visit Preview 017c84f

@techniq
Copy link
Owner

techniq commented Dec 18, 2025

Thanks @es3n1n, I'm taking a look now. Currently throwing a stack track when rendering all the LineChart examples I'm trying to identify the root cause

image image

@techniq
Copy link
Owner

techniq commented Dec 18, 2025

@es3n1n actually this looks to have been introduced upstream in state-refactor (which makes sense as it's still very actively being developed. I'm going to stack this PR up a branch onto docs-v2 instead of state-refactor and if all looks good, we're merge into doc-v2 and I'll pull those changes up into state-refactor. Sorry for the noise.

@techniq techniq changed the base branch from state-refactor to docs-v2 December 18, 2025 15:42
@techniq techniq changed the base branch from docs-v2 to state-refactor December 18, 2025 15:43
@es3n1n
Copy link
Author

es3n1n commented Dec 18, 2025

Ah, I see. Do you want me to rebase to docs-v2 so that it will be easier to merge later?
I clicked through some examples while testing locally, but apparently LineChart was not among them :p

@techniq
Copy link
Owner

techniq commented Dec 18, 2025

@es3n1n I have the rebase completed locally (with a little Claude help to make sure I didn't screw it up 🤣) but looks like you'll need to perform the rebase on your fork

image

Could you rebase locally onto docs-v2 (fwiw I used: git rebase --onto origin/docs-v2 origin/state-refactor pr/es3n1n/734).

... you just replied 🫶. Yes please 😃

@es3n1n es3n1n force-pushed the es3n1n/remove-lodash branch from 017c84f to e3253fa Compare December 18, 2025 16:49
@es3n1n es3n1n changed the base branch from state-refactor to docs-v2 December 18, 2025 16:49
@es3n1n
Copy link
Author

es3n1n commented Dec 18, 2025

Completely missed that notification, but I think we're good to go now!

Copy link
Owner

@techniq techniq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, and great work!

I was able to tease out an error here and there, but would always disappear after a refresh (or loading the example directly) which is not uncommon with Svelte async / remote functions at the moment.

Example:
Image

Going to merge and keep an eye on any regressions. I also plan to regenerate all 700 example screenshots soon which should give a good indication if we've overlooked any regressions.

Thanks again!

@techniq techniq merged commit 9df9207 into techniq:docs-v2 Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants