This repository was archived by the owner on Apr 17, 2025. It is now read-only.
Changes specific for service-web-formats project #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, can we merge this now or should we wait for the A/B test of FOR-3813 to be over? |
Author
|
I wonder if it's not better to keep this PR opened forever? 🤔 This way we can keep a visual of all the changes made for our use cases with the files tab. Additionally, the version in our package.json can stay the same, it won't have to change every time we add some changes to this lib. WDYT? |
|
Good idea! 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Object.assignwhen defining the__assignhelper.