Post-customstart axes mode failsafe#337
Open
DTV96Calibre wants to merge 3 commits intoteachingtechYT:masterfrom
Open
Post-customstart axes mode failsafe#337DTV96Calibre wants to merge 3 commits intoteachingtechYT:masterfrom
DTV96Calibre wants to merge 3 commits intoteachingtechYT:masterfrom
Conversation
customstart may fail to restore extruder to absolute mode, so reset extruder position and extrusion mode
Author
|
So... the behavior of G90 differs slightly between RepRap and Marlin. Marlin also sets the extruder axis to absolute mode but RepRap requires the use of M82. Both support M82, so I'll re-add that in the next commit. |
Owner
|
G90 and M82 are already in the start gcode. Is the important addition here the G92 E0.0? |
Author
|
The problem is that the custom start gcode might undo the earlier G90 and M82. The changes in this pull request reapplies G90 and M82 after the custom start gcode. We can't trust the user (i.e. me) to tidy up after themselves, so we cleanup after them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Simplify3D generated G-Code uses absolute extruder and XYZ position values. If the user's custom start gcode sets it to relative and fails to set it back, the printer will be operating in the wrong mode.
Notably PrusaSlicer profiles for Prusa machines includes start g-code that sets the extruder to relative mode (M83) and doesn't change it back.