Skip to content

fix(server): forward Authorization header on sandbox proxy routes #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
unofn merged 1 commit into from
Jul 2, 2026
Merged

fix(server): forward Authorization header on sandbox proxy routes #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions server/opensandbox_server/api/proxy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,11 @@
"upgrade",
}

# Headers that shouldn't be forwarded to untrusted/internal backends
# Headers that shouldn't be forwarded to untrusted/internal backends.
# "authorization" is intentionally forwarded: in-sandbox services authenticate
# clients with scoped bearer tokens, and the k8s wildcard ingress-gateway
# (which bypasses this proxy) already forwards it.
SENSITIVE_HEADERS = {
"authorization",
"cookie",
SANDBOX_API_KEY_HEADER.lower(),
}
Expand Down
4 changes: 2 additions & 2 deletions server/tests/test_routes_proxy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ def get_endpoint(sandbox_id: str, port: int, resolve_internal: bool = False) ->
assert "connection" not in lowered_headers
assert "upgrade" not in lowered_headers
assert "trailer" not in lowered_headers
assert "authorization" not in lowered_headers
assert lowered_headers.get("authorization") == "Bearer top-secret"
assert "cookie" not in lowered_headers
assert SANDBOX_API_KEY_HEADER.lower() not in lowered_headers
assert "x-hop-temp" not in lowered_headers
Expand Down Expand Up @@ -515,7 +515,7 @@ def get_endpoint(sandbox_id: str, port: int, resolve_internal: bool = False) ->
lowered_headers = {
key.lower(): value for key, value in (call["additional_headers"] or {}).items()
}
assert "authorization" not in lowered_headers
assert lowered_headers.get("authorization") == "Bearer top-secret"
assert "cookie" not in lowered_headers
assert "origin" not in lowered_headers
assert lowered_headers["opensandbox-ingress-to"] == "sbx-123-44772"
Expand Down