Skip to content

[ fix ] avoid memory leak from repeated function creation on function… #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MarcelineVQ wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[ fix ] avoid memory leak from repeated function creation on function… #89

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions Auras.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ local GetSpellName = GetSpellName
local UnitIsFriend = UnitIsFriend
local UpdateTime, LastUpdate = 0.05, 0
local path, duration, text, count, time
local func_table = {}

function MPOWA:OnUpdate(elapsed)
LastUpdate = LastUpdate + elapsed
Expand Down Expand Up @@ -120,7 +121,11 @@ function MPOWA:OnUpdate(elapsed)
end

if (path["funct"]) then
local f = loadstring(path["funct"])
local f = func_table[cat]
if not f then
f = loadstring(path["funct"])
func_table[cat] = f
end
if f ~= nil then
if f() and self.frames[cat][1]:IsVisible() then
self:FShow(cat)
Expand Down Expand Up @@ -196,7 +201,11 @@ function MPOWA:OnUpdate(elapsed)
self:FHide(cat)
end
if (path["funct"]) then
local f = loadstring(path["funct"])
local f = func_table[cat]
if not f then
f = loadstring(path["funct"])
func_table[cat] = f
end
if f ~= nil then
if f() and self.frames[cat][1]:IsVisible() then
self:FShow(cat)
Expand Down