Conversation
|
|
||
| var out_len = m if not trans else n | ||
|
|
||
| # Can't pass a Bool to GPU kernel |
| # Can't pass a Bool to GPU kernel | ||
| var trans_i = 1 if trans else 0 | ||
|
|
||
| @parameter |
Collaborator
There was a problem hiding this comment.
I see now why this fixes everything haha
src/level2/gemv_device.mojo
Outdated
| block_dim=TBsize, | ||
| ) | ||
| else: | ||
| return |
Collaborator
There was a problem hiding this comment.
Can we do any form of throwing an error here?
| ctx: DeviceContext, | ||
| ) raises: | ||
|
|
||
| # NOTE: add error checking here? |
Collaborator
There was a problem hiding this comment.
Possibly just revisit with the issue Jonah made #34 ?
Owner
Author
There was a problem hiding this comment.
We need to meet and discuss where and how much error checking we want to implement
src/testing_utils/testing_utils.mojo
Outdated
| return error_norm == Scalar[dtype](0) | ||
|
|
||
| var err = error_norm / denom | ||
| # print("DEBUG: err =", err) |
jacksonmowry
approved these changes
Feb 25, 2026
Collaborator
jacksonmowry
left a comment
jacksonmowry
left a comment
There was a problem hiding this comment.
All looks good! Thanks for taking the time to implement the error checking function from blas++
ger implementation, 32/64 split
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@WestonJB @jacksonmowry, please see if matched what BLAS++ does for error checks: https://github.com/icl-utk-edu/blaspp/blob/master/test/check_gemm.hh