Skip to content

ger implementation, 32/64 split#56

Merged
tdehoff merged 4 commits intomainfrom
jackson/ger
Feb 25, 2026
Merged

ger implementation, 32/64 split#56
tdehoff merged 4 commits intomainfrom
jackson/ger

Conversation

@jacksonmowry
Copy link
Collaborator

@jacksonmowry jacksonmowry commented Feb 20, 2026

Closes: #39

I split out the 32/64 bit implementations but with the way Mojo currently works (at least as far as I can tell) we'll have to also split the tests (unless we want to essentially duplicate all the code within a test function for both precision levels).

I guess the compiler is unable to infer that the comptime dtype parameter is either DType.float32 or DType.float64 meaning passing a buffer of type UnsafePointer[Dtype.float32, ImmutAnyOrigin] is not equivalent to UnsafePointer[dtype, ImmutAnyOrigin] with dtype == DType.float32. Hopefully I'm just missing something and we can go back to having a single test.

This implementation also assumes we want to split the cpu dispatch functions into sger and dger, let me know if we'd like to still just have 1 dispatch function with a dtype template parameter.

@tdehoff tdehoff merged commit e50b016 into main Feb 25, 2026
1 check failed
@tdehoff tdehoff deleted the jackson/ger branch February 25, 2026 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ger

2 participants