Conversation
tdehoff
requested changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #39
I split out the 32/64 bit implementations but with the way Mojo currently works (at least as far as I can tell) we'll have to also split the tests (unless we want to essentially duplicate all the code within a test function for both precision levels).
I guess the compiler is unable to infer that the comptime
dtypeparameter is eitherDType.float32orDType.float64meaning passing a buffer of typeUnsafePointer[Dtype.float32, ImmutAnyOrigin]is not equivalent toUnsafePointer[dtype, ImmutAnyOrigin]withdtype == DType.float32. Hopefully I'm just missing something and we can go back to having a single test.This implementation also assumes we want to split the cpu dispatch functions into
sgeranddger, let me know if we'd like to still just have 1 dispatch function with adtypetemplate parameter.