support different platforms (e.g. ARM): rebased to FROM java ... #13
Open
umiddelb wants to merge 1 commit intotdeckers:masterfrom
Open
support different platforms (e.g. ARM): rebased to FROM java ... #13umiddelb wants to merge 1 commit intotdeckers:masterfrom
umiddelb wants to merge 1 commit intotdeckers:masterfrom
Conversation
…removed fixed path prefix to java binary in openhab.conf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I've filed this PR to discuss some changes which makes it easier to port docker-openhab to other platforms (e.g. ARMv7).
FROM java:7 | FROM armv7/armhf-java7will eliminate the link to a platform dependant Java install binary in your Dockerfile. Instead of this you can play around with different Java flavours (and platforms) just by changing the FROM line and nothing else (armv7/armhf-java7 relates to my base Ubuntu Core & Oracle JDK 7 image for ARMv7 devices, e.g. the Raspberry Pi 2, or the ODROID boards).In the consequence I needed to remove the fixed prefix to the java binary used in open openhab.conf.
Now to the downside ... the Docker Java library images are OpenJDK only, if you need Oracle JDK support, you need to build the Docker images by yourself.