Fix panic when sub-agent tool completes after primary agent's turn ends#69
Open
Fix panic when sub-agent tool completes after primary agent's turn ends#69
Conversation
The ToolEvent::Completed handler was unconditionally draining injectable
notifications and calling finish_turn()/begin_turn() on the transcript,
even for sub-agent tool completions. When the primary agent had already
finished its turn, this created an orphaned active turn that nobody would
finish, causing a panic ("Cannot begin turn: previous turn not finished")
on the next user submit.
Guard the notification injection behind an is_primary check so only the
primary agent's tool completions manipulate the transcript turn lifecycle.
https://claude.ai/code/session_01RimYSQyprjibcxqX8XBmrD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ToolEvent::Completed handler was unconditionally draining injectable
notifications and calling finish_turn()/begin_turn() on the transcript,
even for sub-agent tool completions. When the primary agent had already
finished its turn, this created an orphaned active turn that nobody would
finish, causing a panic ("Cannot begin turn: previous turn not finished")
on the next user submit.
Guard the notification injection behind an is_primary check so only the
primary agent's tool completions manipulate the transcript turn lifecycle.
https://claude.ai/code/session_01RimYSQyprjibcxqX8XBmrD