Improve warning/critical match expression and update ReadMe#48
Open
sotrali wants to merge 3 commits intotbh1:masterfrom
Open
Improve warning/critical match expression and update ReadMe#48sotrali wants to merge 3 commits intotbh1:masterfrom
sotrali wants to merge 3 commits intotbh1:masterfrom
Conversation
Added spaces after #'s to make use of Github's markdown rendering (currently the #'s are not actually creating headers and are just being displayed as plaintext).
Modified "invalid.deprecated.notes" warning/critical regular expression to better match documentation.
Modified "invalid.deprecated.notes" warning/critical regular expression to better match documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fork has two purposes:
For Purpose 1:
In the original documentation, there is an example of this where text between two exclamation points is highlighted, such as:
!! HIGHLIGHTED TEXT !!
I found that in practice, this does not accurately reflect the regex used to detect the super important emphasis.
The original REGEX highlights every character on a line found after a single exclamation point, which makes organic note-taking look strange with the highlighting occurring seemingly at random places.
I much preferred how the example screenshot demonstrates this feature, so I tuned the regex to behave as such.
Now, it will highlight any and all text (across multiple lines) ONLY between unique sets of two exclamation points.
For Purpose 2:
The current README has markdown headers, but they aren't properly formatted.
As of now, the #'s are not separated from the text with a space, causing the headers to be rendered as plaintext. By adding that space, the README becomes a bit more readable!