Skip to content

Fix TODOs in umxDoC.R #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
google-labs-jules wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Fix TODOs in umxDoC.R #259

google-labs-jules wants to merge 1 commit into from

Conversation

@google-labs-jules
Copy link

@google-labs-jules google-labs-jules bot commented Jan 12, 2026

Implemented fixes for several TODOs in R/umxDoC.R.

  1. Added validation to prevent variable names that conflict with internal matrix names.
  2. Implemented calculation of starting mean values from the data (for raw data inputs).
  3. Updated umxSummaryDoC to correctly label the 'D' component in ADE models when dzCr suggests dominance.

PR created automatically by Jules for task 11372557942802759989 started by @tbates

@google-labs-jules
Fix TODOs in umxDoC.R: reserved names, start means, summary labels
101acc3 
- Add check for reserved names in umxDoC (a, c, e, etc.)
- Calculate better start values for means in umxDoC using observed data means (if raw data available)
- Update umxSummaryDoC to label component as 'D' if dzCr is 0.25 (ADE model)
@google-labs-jules
Copy link
Author

google-labs-jules bot commented Jan 12, 2026

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

0 participants