Adds TaskWikiOpen command

[nkakouros]

This addresses #262.

[nkakouros]

This PR is in a first candidate state.

I couldn't think of a way to test the two new commands, any help would be great if you think they are needed.

I also decided to add a new config option instead of parsing the taskopenrc. To parse the taskopenrc, it can be loaded as an ini file and the relevant option can be extracted. But I thought this was more convoluted.

[nkakouros]

I managed to add some tests for the new commands. However, I cannot think of a way to add a test that checks if TaskWikiOpen actually succeeds.

@liskin Would you happen to have some insight to share?

[liskin]

However, I cannot think of a way to add a test that checks if TaskWikiOpen actually succeeds.

Overriding PATH and using a dummy xdg-open that does something we can later check comes to mind.

[nkakouros]

I just came up with a much better solution to the note problems. TaskWikiOpen can use sth like:

taskopen -c /path/to/config -n <task-id> -x 'echo "$FILE"'

to read the file that taskopen would open as the note. Then, it can simply edit the file in the current vim.

[sdondley]

What is the status of this?

[nkakouros]

What is the status of this?

I will address the comments and make this PR more proper soon.

[tbabej]

For what it's worth, I think this is a worthy addition to taskwiki and I'd be happy merging this once the MR is ready.

[sdondley]

I've hacked together a solution here for using taskopen with taskwiki: #386

I've been using it about a week. Not sure if it's useful or not to your efforts but it may be worth looking at.

[nkakouros]

I completely rewrote the commands, it was much more involved than expected. I removed the old tests, I need to write more. Is there any comment?

[tbabej]

I completely rewrote the commands, it was much more involved than expected. I removed the old tests, I need to write more. Is there any comment?

I had a look, the PR generally looks OK. I do wish that styling changes were at least a separate commit though, looks like black auto-formatted that one file you were editing there 🙂

[nkakouros]

I completely rewrote the commands, it was much more involved than expected. I removed the old tests, I need to write more. Is there any comment?

I had a look, the PR generally looks OK. I do wish that styling changes were at least a separate commit though, looks like black auto-formatted that one file you were editing there 🙂

Ooops, you are right... I will revert them back.

[sdondley]

Can I suggest adding a feature to turn this feature off (and have it on by default).

[nkakouros]

Can I suggest adding a feature to turn this feature off (and have it on by default).

Do you want to keep the mappings clean? What is the use case?

[sdondley]

@nkakouros I rolled my own solution for using taskopen. I guess I could change my map.

[nkakouros]

This is currently on hold until the test suite is fixed.

[jahagirdar]

This is currently on hold until the test suite is fixed.

Any ETA on this?

[nkakouros]

#429 and free time are blocking this.

[sakarimov]

i tried to apply this patch to my setup, but i got this error

taskopen is not installed
taskopen failed to open task 40
Press ENTER or type command to continue

even though i have installed taskopen, and it works from the terminal