run/logs: tail array (<=32) follow via resolog#15
Merged
Conversation
Second integration step. Array jobs within the tail cap now tail through
resolog: the batch resolver expands the array into one Source per child
("batch[N]"), and childSink renders each behind its colored, width-aligned
prefix — byte-identical to the home-grown output. batchkoi keeps a parallel
status poll (waitForArrayTerminal) for [STATUS], the progress bar, the final
JobDetail and exit-on-FAILED; resolog owns tail shutdown via Done + grace.
Arrays larger than maxTailedChildren (32) keep the home-grown TPS-bounded
pager — that path is unchanged.
Tests: TestChildSink (prefix/width/single-vs-array mapping) and the existing
TestLogsArrayFollow (now exercises the resolog path) are green; fakeLogs.calls
is now atomic since children tail concurrently.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second step of the batchkoi → resolog integration (PR-3).
What changes
Array jobs within the tail cap (
size <= 32) now tail through resolog:waitAndTailArraydispatchessize <= maxTailedChildrento a newtailArrayViaResolog(resolog.Tail + resolver/batch's array expansion + backend/poll +childSinkwith width+color). Output is byte-identical to the home-grown tailer (childSinkreuseschildPrefix).waitForArrayTerminal) for the[STATUS]lines, the progress bar, the finalJobDetail, and exit-on-FAILED. resolog owns tail shutdown (Done + grace); batchkoi never cancels the tail.What stays home-grown
> 32keep the interactive TPS-boundedchildPagerpath, unchanged (migrating it would lose the 25-TPS quota protection — that's a future resolog enhancement: multi-stream sources).Tests
TestChildSink: label→index→prefix mapping incl. width alignment and single-job (no prefix).TestLogsArrayFollownow runs through the resolog path and stays green.fakeLogs.callsmade atomic (children tail concurrently); full-racesuite green.🤖 Generated with Claude Code