fix: make deprecated Client initializer backward-compatible#160
Open
shuofengzhang wants to merge 1 commit intotavily-ai:masterfrom
Open
fix: make deprecated Client initializer backward-compatible#160shuofengzhang wants to merge 1 commit intotavily-ai:masterfrom
shuofengzhang wants to merge 1 commit intotavily-ai:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Clientinitializer so it correctly forwards parameters toTavilyClient.Client(api_key="...")Client({"api_key": "..."})Client("...")Why
Clientclass currently passes a single positional argument directly toTavilyClient, which can mis-handle initialization data (for example, passing a dict as the API key).TavilyClient.Testing
source .venv/bin/activate && pytest -qNote
Low Risk
Low risk: changes are limited to a deprecated wrapper constructor and add tests; core request/response logic is untouched.
Overview
Restores backward-compatible initialization for the deprecated
Clientwrapper by acceptingClient(api_key=...),Client({"api_key": ...}), andClient("...")and forwarding them as proper keyword args toTavilyClient.Adds regression tests asserting the
DeprecationWarningis emitted and the API key is set correctly for keyword-arg and legacy-dict construction.Written by Cursor Bugbot for commit da30ade. This will update automatically on new commits. Configure here.