fix(macos): avoid panics on missing URL (fix #1752)#1753
Open
Buncys wants to merge 1 commit into
Open
Conversation
c21dc63 to
1530e67
Compare
1530e67 to
fd445e9
Compare
Contributor
|
Fixes to non-trivial issues are nearly impossible to judge without a reproducer. |
Contributor
Author
|
Here is the reproducer: let event_loop = EventLoop::new();
let window = WindowBuilder::new().build(&event_loop).unwrap();
let web_view = WebViewBuilder::new().build(&window).unwrap();
let _ = dbg!(web_view.url()); // <- panics on macosRunning this produces: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes
unwrapcalls in two code paths, as requested in #1752.Affected code paths
src/wkwebview/mod.rs,url_from_webview()src/wkwebview/navigation.rs,navigation_policy()Changes
url_from_webview()now returnsOk("")when URL is unavailable, which is consistent with other platformsnavigation_policy()Fixes #1752