fix(build): copy newly added files from resource directories#15629
Open
tenderdeve wants to merge 1 commit into
Open
fix(build): copy newly added files from resource directories#15629tenderdeve wants to merge 1 commit into
tenderdeve wants to merge 1 commit into
Conversation
The resource copy only emitted `cargo:rerun-if-changed` for the individual files resolved at build time. When a new file was added to a resource directory, cargo had no reason to re-run the build script, so the file was never copied until an unrelated rebuild happened. Track every walked/globbed resource directory in `ResourcePathsIter` and emit a `rerun-if-changed` for each after copying, so adding or removing a file inside a resource directory re-runs the script and picks it up. Closes tauri-apps#14992
Contributor
Package Changes Through e42b1c2There are 2 changes which include tauri-build with patch, tauri-utils with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #14992
copy_resourcesonly emittedcargo:rerun-if-changedfor the individual files it resolved at build time. Since resource dirs/globs are expanded once during the build, a file added to a resource directory afterwards is unknown to cargo — the build script never re-runs, so the new file isn't copied until some unrelated change (editingtauri.conf.json,build.rs, or an already-tracked file) forces a rebuild. The documented workaround is to manually addcargo:rerun-if-changed=<dir>.Fix:
ResourcePathsIternow records each directory it walks and the fixed base of each glob, exposed viarerun_if_changed().copy_resourcesemits arerun-if-changedfor each after copying, so adding or removing a file inside a resource directory re-runs the script and copies it.Added a unit test covering directory, glob, and single-file patterns. Existing resource-path tests still pass.