Updating universal buffer size

[mayankmahavar1mg]

---

DeputyDev generated PR summary:

---

Size XXL: This PR changes include 1000+ lines and should take approximately 6+ hours to review, potentially spread across multiple sessions

---

The pull request titled "Updating universal buffer size" involves several changes across multiple files. Here's a summary of the key modifications:

1. Buffer Size Update:

   • The buffer size for BufferedInputStream in WebCacheManager.kt is updated to 32 * 1024, which is 32KB. This likely aims to optimize the reading of files from the cache.

2. Configuration and Environment Adjustments:

   • The .eslintrc file has been reformatted for consistency, and a new rule for react-compiler/react-compiler has been added.
   • The Babel configuration has been moved from babel.config.json to a new babel.config.js file, introducing TypeScript support with @babel/preset-typescript.
   • The package.json file now includes additional dependencies such as @babel/preset-typescript, babel-plugin-react-compiler, cross-env, and react-compiler-runtime.

3. Codebase Enhancements:

   • The MainActivity.kt file has been refactored to use properties.getProperty instead of jsonObject.optString for configuration values.
   • The utils.js file has corrected a prompt string from "CSS pattern" to "Cache pattern".
   • The build and development scripts have been updated to use process.cwd() instead of process.env.PWD, making them more cross-platform compatible. Additionally, cross-env is used to set environment variables across different operating systems.
   • The start.js script now includes handling for Windows platforms using spawn for asynchronous command execution.

4. Webpack Configuration:

   • TypeScript support is added to the Webpack configuration with .ts and .tsx file extensions.
   • The splitChunks configuration in development.client.babel.js and production.client.babel.js now allows for custom configurations if provided.

5. Error Handling and Lifecycle Methods:

   • New lifecycle methods like safeCall have been introduced for safely executing user-defined functions, ensuring errors during execution do not crash the server.
   • Additional hooks for error handling (onRenderError, onRequestError, etc.) are integrated to allow custom handling of server-side events.

This PR improves the codebase by enhancing the configuration, optimizing performance, and increasing cross-platform compatibility. It also adds better error handling and support for TypeScript. The changes seem to align with the title, focusing on improving the buffer size and related configurations.

---

DeputyDev generated PR summary until d6b3733

[deputydev-agent]

DeputyDev has started reviewing your pull request.

[deputydev-agent]

SECURITY: Configuration values are now being read from properties instead of a JSON object. This change could potentially expose sensitive information if the properties file is not properly secured. Ensure that the properties file is stored securely and not accessible to unauthorized users. Severity: High

// Ensure that the properties file is stored in a secure location
// and implement proper access controls
val secureProperties = SecurePropertiesLoader.load("secure_config.properties")
AndroidConfig(
    buildType = secureProperties.getProperty("buildType", "debug"),
    cachePattern = secureProperties.getProperty("cachePattern", ""),
    emulatorName = secureProperties.getProperty("emulatorName", ""),
    sdkPath = secureProperties.getProperty("sdkPath", "")
)

[deputydev-agent]

MAINTAINABILITY: The babel configuration is duplicated in both babel.config.client.js and babel.config.ssr.js. This violates the DRY principle and may lead to maintenance issues in the future.

Create a common babel configuration file and import it in both `babel.config.client.js` and `babel.config.ssr.js`. For example:

// common-babel-config.js
module.exports = {
    presets: [
        ["@babel/preset-typescript", { isTSX: true, allExtensions: true }],
        ["@babel/preset-env", { targets: { node: "current" } }],
        ["@babel/preset-react", { runtime: "automatic" }],
    ],
    plugins: ["@loadable/babel-plugin"],
};

// In babel.config.client.js and babel.config.ssr.js
const commonConfig = require('./common-babel-config');
export default {
    ...commonConfig,
    // Add any client or SSR specific configurations here
};

[deputydev-agent]

ERROR: The introduction of React Compiler without proper fallback might cause runtime errors if the compiler fails or is not available in certain environments.

// Add a try-catch block to handle potential compiler errors
try {
  // ... React Compiler configuration ...
} catch (error) {
  console.warn('React Compiler initialization failed:', error);
  // Fallback to standard React configuration
}

[deputydev-agent]

MAINTAINABILITY: The splitChunks configuration is duplicated in both development.client.babel.js and production.client.babel.js. This violates the DRY principle and may lead to inconsistencies if one file is updated but not the other.

Create a common configuration file for splitChunks and import it in both development and production configs. For example:

// common-split-chunks-config.js
module.exports = {
    cacheGroups: {
        commonVendor: {
            test: /[\\/]node_modules[\\/](react|react-dom|react-redux|react-router|react-router-dom|redux|redux-thunk|axios|react-loadable-visibility|react-helmet-async|react-fast-compare|react-async-script|babel|@loadable\/component|catalyst)[\\/]/,
            name: "commonVendor",
            minSize: 30000,
        },
        utilityVendor: {
            maxInitialRequests: Infinity,
            chunks: "all",
            reuseExistingChunk: true,
            minRemainingSize: 1000,
            test: /[\\/]node_modules[\\/]/,
            name(module) {
                const moduleFileName = module
                    .identifier()
                    .split("node_modules")?.[1]
                    ?.split("/")
                    .reverse()
                    .slice(0, 3)
                    .reduce((item, current) => {
                        item = current + "." + item
                        return item
                    }, [])
                return `npm.${moduleFileName}`
            },
        },
    },
};

// In development.client.babel.js and production.client.babel.js
const commonSplitChunksConfig = require('./common-split-chunks-config');
// ...
optimization: {
    // ...
    splitChunks: customWebpackConfig.splitChunksConfig || commonSplitChunksConfig,
},

[deputydev-agent]

ERROR: The modification to error handling in the server renderer (safeCall function) might suppress important errors, making debugging more difficult in production environments.

// Modify the safeCall function to log errors more verbosely
const safeCall = (fn, ...args) => {
    try {
        if (!fn) return;
        if (typeof fn !== "function") {
            console.error("Invalid lifecycle method defined in server/index.js");
            return;
        }
        return fn(...args);
    } catch (e) {
        console.error(`Error in ${fn.name}:`, e);
        // Consider re-throwing the error or notifying an error tracking service
    }
};

[deputydev-agent]

DeputyDev has completed a review of your pull request for commit d6b3733.