Reliability & dev server memory improvements#199
Open
Uttkarsh-Srivastava wants to merge 9 commits intofeature/fix-memory-usagefrom
Open
Reliability & dev server memory improvements#199Uttkarsh-Srivastava wants to merge 9 commits intofeature/fix-memory-usagefrom
Uttkarsh-Srivastava wants to merge 9 commits intofeature/fix-memory-usagefrom
Conversation
…t-core into expose-gc
…ross platforms Replaced Node.js native --watch-path flags on Windows with chokidar-based watching (already used on Mac/Linux), eliminating the double-trigger bug where a single /server file change caused both a process-level restart and an in-process Express restart simultaneously. Also fixes EADDRINUSE race condition by introducing restartServer() which nulls serverInstance before close(), preventing concurrent chokidar events from each queuing independent startServer() callbacks on the same socket. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
DeputyDev will no longer review pull requests automatically.To request a review, simply comment #review on your pull request—this will trigger an on-demand review whenever you need it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
development.client.babel.js; SSR now runs in a separate process for better memory isolationstartServer.jsnow watchesloadable-stats.json(webpack signal) and the app/serverdirectory; on change it selectively clears the require cache (clearServerCache) and restarts the Express serverrestartServer()nullsserverInstancebeforeclose()to preventEADDRINUSErace conditions when multiple watcher events fire simultaneouslycache: { type: "filesystem" }inbase.babel.jsto reduce memory pressure and speed up incremental rebuildsinline-source-map→eval-cheap-module-source-mapfor lower memory footprint in devreact-refresh/babelplugin tobabel.config.client.jsfor the development envcss-hot-loader— dropped from SCSS and CSS rules (superseded by React Fast Refresh + HMR)--watch-pathflags on Windows; file watching is now handled by chokidar uniformly across platformsrenderer/index.jsalways requires./handlerdirectly; dev/prod branching removed since the cache-clear strategy handles freshness